Skip to content

Add sudo; additional cleanup#1

Merged
luccasmmg merged 1 commit into
masterfrom
add-sudo
Apr 28, 2026
Merged

Add sudo; additional cleanup#1
luccasmmg merged 1 commit into
masterfrom
add-sudo

Conversation

@mpolidori
Copy link
Copy Markdown
Member

@mpolidori mpolidori commented Apr 27, 2026

Note: I changed datapusher URL back to ckan as the domain instead of localhost. This is because datapusher will try to reach localhost and it will be itself. It should be able to reach ckan via ckan as the domain since that should be the name of the container.

Summary by CodeRabbit

  • Updates

    • Upgraded CKAN to version 2.11.4 from 2.10.0
  • Configuration

    • Updated Datapusher callback URL for containerized environments
  • Chores

    • Simplified Docker development environment setup with enhanced system package support

@mpolidori mpolidori requested a review from luccasmmg April 27, 2026 16:58
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 27, 2026

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Free

Run ID: 25dfc82c-6847-43f9-92a4-36b051185dbc

📥 Commits

Reviewing files that changed from the base of the PR and between b71b548 and 1ab4568.

📒 Files selected for processing (6)
  • .env.example
  • ckan/Dockerfile
  • ckan/Dockerfile.dev
  • ckan/setup/prerun.py.override
  • ckan/setup/start_ckan.sh.override
  • ckan/setup/start_ckan_development.sh.override
💤 Files with no reviewable changes (4)
  • ckan/Dockerfile
  • ckan/setup/prerun.py.override
  • ckan/setup/start_ckan_development.sh.override
  • ckan/setup/start_ckan.sh.override

📝 Walkthrough

Walkthrough

CKAN version is updated from 2.10.0 to 2.11.4, the Datapusher callback URL is changed from localhost to the container service hostname, the production Dockerfile is removed, development Dockerfile gains sudo and patch utilities, and multiple setup orchestration scripts are deleted.

Changes

Cohort / File(s) Summary
Configuration
.env.example
CKAN version bumped to 2.11.4; Datapusher callback base URL migrated from http://localhost:5000 to http://ckan:5000 for container service communication.
Docker Images
ckan/Dockerfile, ckan/Dockerfile.dev
Production Dockerfile removed entirely. Development Dockerfile now escalates to root, installs sudo and patch packages, grants ckan user passwordless sudo access, then returns to existing initialization flow.
Setup Scripts
ckan/setup/prerun.py.override, ckan/setup/start_ckan.sh.override, ckan/setup/start_ckan_development.sh.override
All three setup orchestration scripts deleted. Removed functionality includes: database connection checks, CKAN initialization/upgrade, plugin configuration, datastore initialization, Solr schema validation, secret generation, local extension installation, and container bootstrap logic.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 From two-ten up to two-eleven, we hop with cheer,
Localhost bids farewell, containers draw near,
Scripts fade to silence, patches packed tight,
Sudoers and simplicity—the setup takes flight! ✨


Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

Comment @coderabbitai help to get the list of available commands and usage tips.

@luccasmmg
Copy link
Copy Markdown
Member

lgtm

@luccasmmg luccasmmg merged commit c13a78e into master Apr 28, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants