Skip to content

Conversation

@starsinmypockets
Copy link
Contributor

Allow themes to extend routes app routes.

@vercel
Copy link

vercel bot commented Jun 17, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://frontend-v2-git-fork-starsinmypockets-master.datopian1.now.sh

@anuveyatsu
Copy link
Member

@starsinmypockets would it throw an error if you don't have routes.js module in your template? E.g, opendk and eds themes don't need custom routes.

@starsinmypockets
Copy link
Contributor Author

Yes, for this implementation the theme would need a stub. I think this is not a bad pattern since the default theme template could include the placeholder which would serve as a guide for devs... We could add a try / catch that throws an error explaining that this file is required... or a warning..

@starsinmypockets
Copy link
Contributor Author

(If this is approved I can add test coverage)

@starsinmypockets
Copy link
Contributor Author

Closed. This will be picked up in this epic:
#22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants