Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upMore Modular Code & Simpler CLI Output #497
Conversation
joehand
added some commits
Jun 20, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
karissa
Jul 5, 2016
Collaborator
Nice, thanks for the detailed changelog report. It's super important to document how things are changing, good work!
|
Nice, thanks for the detailed changelog report. It's super important to document how things are changing, good work! |
joehand
added
the
review wanted
label
Jul 7, 2016
karissa
reviewed
Jul 7, 2016
| printSwarm() | ||
| }) | ||
| dat.on('download-finished', function () { |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
karissa
reviewed
Jul 7, 2016
| function printStats (data) { | ||
| var stats = dat.stats | ||
| var files = stats.filesTotal |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
karissa
Jul 7, 2016
Collaborator
what items are on .stats and which are on .appendStats and which aren't on either?
karissa
Jul 7, 2016
•
Collaborator
what items are on .stats and which are on .appendStats and which aren't on either?
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
joehand
Jul 7, 2016
Member
@karissa they overlap and could definitely use some improvement/more thought. One issue I keep running into is showing files vs "items" (files + dirs), since hyperdrive uses the combined total for it's count (archive.metadata.blocks).
.appendStats is files, dirs, and bytes calculated on sharing start. .stats is always the current archive stats, which gets updated as files are appended (initially and live).
stats = {
filesTotal: 0,
bytesTotal: 0,
bytesUp: 0,
bytesDown: 0,
rateUp: speedometer(),
rateDown: speedometer()
}
appendStats = {
files: 0,
bytes: 0,
dirs: 0
}
joehand
Jul 7, 2016
Member
@karissa they overlap and could definitely use some improvement/more thought. One issue I keep running into is showing files vs "items" (files + dirs), since hyperdrive uses the combined total for it's count (archive.metadata.blocks).
.appendStats is files, dirs, and bytes calculated on sharing start. .stats is always the current archive stats, which gets updated as files are appended (initially and live).
stats = {
filesTotal: 0,
bytesTotal: 0,
bytesUp: 0,
bytesDown: 0,
rateUp: speedometer(),
rateDown: speedometer()
}
appendStats = {
files: 0,
bytes: 0,
dirs: 0
}
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
karissa
Jul 7, 2016
Collaborator
I'm happy with this! We could just document these values in the README (if we want, even though it's not a public API) and ship it! :)
karissa
Jul 7, 2016
Collaborator
I'm happy with this! We could just document these values in the README (if we want, even though it's not a public API) and ship it! :)
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
lgtm |
joehand commentedJul 5, 2016
•
edited
CLI Goodness! https://www.youtube.com/watch?v=fxKjSyCoqO4
Fixed
Changed
Removed
Added