This repository was archived by the owner on Jun 6, 2024. It is now read-only.
feat: print validation errors in custom key rules#926
Merged
TzlilSwimmer123 merged 13 commits intomainfrom Apr 13, 2023
Merged
Conversation
myishay
reviewed
Apr 11, 2023
myishay
reviewed
Apr 11, 2023
| return &JSONSchemaValidator{} | ||
| } | ||
|
|
||
| var CustomKeyValidationErrorKeyPath = "customKeyValidationErrorKeyPath" |
Contributor
There was a problem hiding this comment.
I see the same peace of code here: https://github.com/datreeio/datree/pull/926/files#r1162390565
I guess one of them is duplicate?
myishay
previously approved these changes
Apr 11, 2023
Contributor
myishay
left a comment
myishay
left a comment
There was a problem hiding this comment.
I think ValidationResults could be renamed to ValidationFailureMessages/ValidationFailedMessages or something like that, but I leave that for you to decide.
Approved
myishay
previously approved these changes
Apr 13, 2023
myishay
approved these changes
Apr 13, 2023
delete-merged-branch
Bot
deleted the
DAT-4992_show_custom_rule_key_validation_errors
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.