Skip to content

Properly check that result is an error#64

Merged
yoshuawuyts merged 1 commit intodatrs:masterfrom
khernyo:nightly-compile-error
Apr 23, 2019
Merged

Properly check that result is an error#64
yoshuawuyts merged 1 commit intodatrs:masterfrom
khernyo:nightly-compile-error

Conversation

@khernyo
Copy link
Copy Markdown
Member

@khernyo khernyo commented Apr 22, 2019

Fixes a compile error in one of the tests on current rust nightly (1.36.0):

error: unused return value of `std::result::Result::<T, E>::is_err` that must be used
  --> src/crypto/key_pair.rs:48:3
   |
48 |   verify(&keypair.public, b"oops", Some(&sig)).is_err();
   |   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |

@khernyo khernyo requested a review from yoshuawuyts April 22, 2019 11:49
Copy link
Copy Markdown
Contributor

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, yes. Excellent catch!

@yoshuawuyts yoshuawuyts merged commit b209cc1 into datrs:master Apr 23, 2019
@khernyo khernyo deleted the nightly-compile-error branch May 6, 2019 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants