Update random-access-storage to 2.0.0#12
Conversation
|
Also I was asked to choose what kind of pull request this was from the template. I assume this is supposed to be a label I add, but labels seem to be disabled for non-contributors. |
| // file.truncate(0).unwrap(); | ||
| // assert_eq!(file.is_empty().unwrap(), true); | ||
| // file.write(0, b"what").unwrap(); | ||
| // assert_eq!(file.is_empty().unwrap(), false); |
There was a problem hiding this comment.
These assertions are disabled, as they require truncate to work.
|
@jackjennings these changes look reasonable to me; agree we should probably figure out why truncate doesn't work, as your reasoning seems sound. If you could make sure tests pass (cargo fmt is failing) then I think we should be good to merge! |
jackjennings
force-pushed
the
update-random-access-storage-2
branch
from
1e2b210 to
499fef4
Compare
|
@yoshuawuyts I rebased — changed the implementation of |
|
|
2 participants
Submitting this pull request because I need some help resolving an issueUpdate: resolved.Checklist
Context
This pull request is in regards to work on this issue to update
usizetou64: datrs/random-access-storage#6As this package would need to update to the upcoming
3.0.0ofrandom-access-storage, I'm attempting to first update to2.0.0, which requires adding a handful of additional methods to theRandomAccesstrait.I've added
lenais_empty, buttruncateis troublesome. I assumed that I could make this implementationdel(0, length), but this throws an error when theoffsetprovided todelis zero. I'm unsure if this is a bug indel, or if I need to provide a more complex implementation oftruncate.I've added failing tests for
truncatebased on the tests inrandom-access-disk.dependabotattempted to make this change previously in this pull request: #9Semver Changes
This would likely be a minor version change, as additional functionality is added, while existing functionality is unchanged.