Merged
Conversation
ecv
approved these changes
Jan 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CLI developers that are importing the activity command need the ability to define how the kubeconfig used by the activity client is created so they can tailor the experience to the CLI they're building.
For example, a normal kubectl-plugin would use the standard k8s kubectl file on the machine to connect to the kubernetes cluster. But when building a CLI for datumctl, we want to pass the kubeconfig into the CLI command through the factory so the CLI can build the appropriate kubeconfig based on the context the user is querying the system in.
Details
This PR updates the activity command to support passing in a kubeconfig factory to use for building the REST config to use with the k8s client.
Relates to datum-cloud/enhancements#536