Fix inhibit rule silencing all warning alerts#178
Merged
Conversation
The severity-based inhibit rule (critical suppresses warning) used equal: [component] but did not require the component label to exist. When both source and target lack the label, alertmanager treats them as matching, causing any critical alert to suppress all warnings across the entire cluster. Add component=~".+" matchers to both source and target so the rule only applies to alerts that actually have a component label.
scotwells
changed the title
scotwells
requested review from
JoseSzycho,
drewr,
ecv,
kevwilliams,
slindseysr and
zachsmith1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A severity-based inhibit rule intended for activity system alerts was accidentally suppressing all warning alerts across the entire cluster. Any critical alert (like
PolicyBindingsNotReadyorCertManagerCertNotReady) was silencing every warning alert — including unrelated ones likeKubePodCrashLoopingandKubeJobFailed.The fix scopes the rule so it only applies to alerts that have a
componentlabel, which limits it to activity system alerts as originally intended.Test plan
componentlabelsRelates to datum-cloud/infra#277