feat: default Connector connectorClassName to iroh-quic-tunnel#151
Merged
zachsmith1 merged 2 commits intomainfrom Apr 30, 2026
Merged
feat: default Connector connectorClassName to iroh-quic-tunnel#151zachsmith1 merged 2 commits intomainfrom
zachsmith1 merged 2 commits intomainfrom
Conversation
Switch DEFAULT_CONNECTOR_CLASS_NAME from datum-connect to iroh-quic-tunnel so newly-created Connectors target the renamed class that Milo will start provisioning on every project. Older builds of this app continue to resolve against the legacy datum-connect class on existing projects until they age out. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
scotwells
previously approved these changes
Apr 30, 2026
The dep was declared with a bare git URL and no rev pin. Combined with bundle CI's `cargo generate-lockfile` step (which discards the committed lockfile before `dx bundle --locked`), every CI run resolved upstream HEAD. Upstream just landed a Select API change (`value` is now `Option<ReadSignal<Option<T>>>` and `placeholder` was removed), breaking the bundle build with no source changes on our side. Pin to ffbc750 (the rev currently in Cargo.lock and the last known to build cleanly), matching the same approach used for the recent pkcs8 pin. Bumps should be deliberate going forward. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
scotwells
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DEFAULT_CONNECTOR_CLASS_NAMEfromdatum-connecttoiroh-quic-tunnel.datum-cloud/miloprovisions the newiroh-quic-tunnelConnectorClass on every project (existing projects keep their legacydatum-connectclass as well, so older builds still resolve).metadata.generateNameprefix is intentionally left asdatum-connect-for now; that is cosmetic resource naming, not the class ref.Test plan
iroh-quic-tunnel.datum-connect) continue to work against existing projects.🤖 Generated with Claude Code