fix: prevent unauthorized IDP linking via session validation#45
Merged
JoseSzycho merged 2 commits intomainfrom Jan 13, 2026
Merged
fix: prevent unauthorized IDP linking via session validation#45JoseSzycho merged 2 commits intomainfrom
JoseSzycho merged 2 commits intomainfrom
Conversation
scotwells
approved these changes
Jan 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: This PR addresses a critical security vulnerability in the IDP linking flow by adding server-side session validation to prevent unauthorized account takeover.
Security Issue: Previously, a malicious user could potentially link their identity provider (e.g., Google, GitHub) to another user's account by manipulating the userId parameter during the OAuth callback flow. This would allow them to gain unauthorized access to the victim's account.
Fix: Added server-side validation in the IDP linking success handler that: