Initial implementation of workload placement controller, scheduler, and workload validation#3
Merged
joshlreese merged 1 commit intointegration/datum-pocfrom Nov 22, 2024
Conversation
…nd workload validation. Needstest suite impl.
scotwells
approved these changes
Nov 20, 2024
Base automatically changed from
feature/bootstrap-compute-apis
to
integration/datum-poc
November 22, 2024 19:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial implementation of the following controllers:
WorkloadDeploymentfor each placement that can be satisfied by a cluster. It's important to note that this controller does not schedule the deployment.WorkloadDeploymentto a candidate cluster. It is possible for multiple clusters to satisfy a deployment, right now only the first will be chosen. In the future, a scoring based scheduler will be desired.NetworkBindingfor each network that a workload deployment is attached to via a network interface. This network binding includes topology information, such as which cluster the deployment was scheduled to, and what city that deployment is in. This information is ultimately used by the Network Services Operator to create aNetworkContextfor each unique network binding topology, and is what drives subnets, subnet claims, and other future allocations within that network context.This PR also bootstraps the validation logic for workloads and workload instances. One interesting highlight here is the use of a
SubjectAccessReviewwithin webhook validation to ensure that the API user has appropriate permissions to attach to a particular network. This can be used in the future for access to images, or other referenced entities.Important
Much work still needs to be completed on the test suite.