Conversation
scotwells
previously approved these changes
Aug 21, 2025
scotwells
approved these changes
Sep 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors how the webhook server determines the cluster context for incoming requests. The main change is to extract the cluster name from the
UserInfo.Extrafield in the admission request, rather than from the request path, and to set the cluster context accordingly. This simplifies the context propagation and removes dependencies on URL parsing.Cluster context extraction improvements:
clusterFromExtraininternal/webhook/util.goto extract the cluster name from theUserInfo.Extrafield, specifically using the keyiam.miloapis.com/parent-name.Registermethod inclusterAwareWebhookServer(internal/webhook/server.go) to wrap the webhook handler and inject the cluster context based onUserInfo.Extra, replacing the previous logic that parsed the cluster name from the request path.