-
Notifications
You must be signed in to change notification settings - Fork 2
output wrapper lib #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
joshlreese
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @sullivtr, great to see you. Thanks for the PR so early on!
I left some thoughts on the table building approach, and the marshaling changes.
c4b79d5 to
e840387
Compare
…his to break if we change the data model
scotwells
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the early contribution @sullivtr! Just some minor feedback on the UX, but I'm good with the changes as is.
|
(Sorry had to recommit because some ineffective code got added by accident when I was rebasing) |
Saw the previous MR adding the outputs for list orgs. Wanted to contribute to the output library. This adds the following: