Skip to content

Conversation

@sullivtr
Copy link
Contributor

@sullivtr sullivtr commented Dec 30, 2024

Saw the previous MR adding the outputs for list orgs. Wanted to contribute to the output library. This adds the following:

  • output package containing output.go, which provides the CLIPrint() func used to print yaml, json, or table to stdout, dependent on the cli input for output format.

Copy link
Contributor

@joshlreese joshlreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @sullivtr, great to see you. Thanks for the PR so early on!

I left some thoughts on the table building approach, and the marshaling changes.

joshlreese
joshlreese previously approved these changes Dec 30, 2024
@sullivtr sullivtr force-pushed the main branch 3 times, most recently from c4b79d5 to e840387 Compare December 30, 2024 21:44
scotwells
scotwells previously approved these changes Dec 30, 2024
Copy link
Contributor

@scotwells scotwells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the early contribution @sullivtr! Just some minor feedback on the UX, but I'm good with the changes as is.

@sullivtr sullivtr dismissed stale reviews from scotwells and joshlreese via 8d749b7 December 30, 2024 23:16
@sullivtr
Copy link
Contributor Author

(Sorry had to recommit because some ineffective code got added by accident when I was rebasing)

@scotwells scotwells merged commit 2a367b9 into datum-cloud:main Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants