fix: show DNS record changes in the activity feed#50
Merged
Conversation
Several DNSRecordSet create/update/delete/system activity rules built their summary from annotations or spec fields that the rule's match did not guarantee were present. When a record set lacked the dereferenced key, summary evaluation errored (no such key) and the activity event was dead-lettered, so the operation never appeared in the activity feed. Tighten each affected rule's match so events missing a field fall through to the existing generic and last-resort fallback rules instead of erroring. Key changes: - A/AAAA, CNAME, ALIAS, MX create/update rules now require the display-value annotation their summary reads - Rules whose summary or match reads spec.recordType now require has(...spec.recordType): type-specific create/update, create/update -other-annotated, create/update-from-request, delete-from-response, and both system-create rules - Summary wording is unchanged; the fallback chain (generic record-type summary, then "a DNS record") requires no field access and stays safe Claude-Session: https://claude.ai/code/session_01KnYuL5Pf1R5ysZoxxNkKiu
scotwells
changed the title
mattdjenkinson
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Adding or changing a DNS record should show up in your activity feed. For some records that entry was quietly going missing. This makes DNS changes show up reliably — and when a friendly label isn't available, it gracefully falls back to a simple, still-useful description instead of dropping the entry entirely.
What changed