fix: use PascalCase for audit scope type annotations#518
Merged
Conversation
Align scope.type annotation values with Kubernetes Kind naming convention and how Milo sets parent-type in user.extra: - "organization" → "Organization" - "project" → "Project" - "user" → "User" - "global" remains lowercase (internal default, not from user.extra) This aligns with the activity service which expects PascalCase values for tenant scoping in ClickHouse queries. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
JoseSzycho
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Audit log scope annotations were being lowercased before being written, but the activity service queries for PascalCase values. This caused org/project-scoped activity queries to return no results.
What changed
The
platform.miloapis.com/scope.typeannotation now uses the same casing as theparent-typein user.extra:Organization(wasorganization)Project(wasproject)User(wasuser)globalstays lowercase since it's an internal defaultBackground
Milo sets
iam.miloapis.com/parent-typeas"Project","Organization", etc. (PascalCase). The audit filter was converting these to lowercase when setting the scope annotation, but the activity service expects PascalCase for ClickHouse queries.🤖 Generated with Claude Code