Skip to content

chore: add display names and descriptions to remaining system roles#520

Merged
kevwilliams merged 2 commits intomainfrom
feat/role-display-names-complete
Mar 12, 2026
Merged

chore: add display names and descriptions to remaining system roles#520
kevwilliams merged 2 commits intomainfrom
feat/role-display-names-complete

Conversation

@kevwilliams
Copy link
Copy Markdown
Contributor

Summary

  • Adds kubernetes.io/display-name and kubernetes.io/description annotations to 46 roles missed in #bda5436
  • Covers IAM platform access approvals/rejections/invitations, IAM roles, user deactivations/invitations, notification contacts/groups/emails, quota service roles (quota-admin, quota-manager, quota-operator), and organization-creator
  • Two roles that already had description (iam-user-preferences-manager, iam-user-self-manage) received only the missing display-name

Test plan

  • Verify annotations are present on all updated roles with kubectl get roles -n datum-cloud -o yaml and kubectl get roles -n milo-system -o yaml
  • Confirm no role is missing either annotation after this + the previous commit

Adds kubernetes.io/display-name and kubernetes.io/description annotations
to all roles that were missed in the previous pass, including IAM platform
access, invitations, user deactivations, notification contacts/groups/emails,
quota service roles, and the organization-creator role.
@kevwilliams kevwilliams requested a review from scotwells March 12, 2026 15:54
@joggrbot

This comment has been minimized.

🤖 Automatically added newlines to 4 file(s)

Co-Authored-By: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown
Contributor

🤖 I automatically added missing newlines at the end of 4 file(s) in this PR.

All files should now end with a newline character as per coding standards.

@cla-assistant
Copy link
Copy Markdown

cla-assistant bot commented Mar 12, 2026

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ kevwilliams
❌ github-actions[bot]
You have signed the CLA already but the status is still pending? Let us recheck it.

1 similar comment
@cla-assistant
Copy link
Copy Markdown

cla-assistant bot commented Mar 12, 2026

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ kevwilliams
❌ github-actions[bot]
You have signed the CLA already but the status is still pending? Let us recheck it.

@kevwilliams kevwilliams merged commit 1922088 into main Mar 12, 2026
1 of 2 checks passed
@kevwilliams kevwilliams deleted the feat/role-display-names-complete branch March 12, 2026 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants