feat: add organization-scoped IAM roles#532
Merged
Conversation
The existing iam-admin role includes permissions for platform-level
resources (protectedresources, users, roles) that are not scoped to
organizations. The new iam-organization-{viewer,editor,admin} roles
provide org-scoped IAM management covering only resources that have
Organization as a parent: groups, groupmemberships, userinvitations,
and policybindings.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
2 tasks
Contributor
Author
|
Tracking issue: datum-cloud/auth-provider-openfga#80 |
kevwilliams
approved these changes
Mar 23, 2026
scotwells
added a commit
to datum-cloud/datum
that referenced
this pull request
Mar 23, 2026
## Summary The `owner` role previously inherited `iam-admin`, which includes permissions for platform-level resources (`protectedresources`, `users`) that have no Organization parent. Granting those permissions at the organization level gives access broader than intended. This PR switches to `iam-organization-admin` (introduced in datum-cloud/milo#532), which covers only IAM resources that are scoped to an organization: - `groups` and `groupmemberships` - `userinvitations` - `policybindings` The platform-level IAM permissions (`users.*`, `protectedresources.*`, `roles.*`) are no longer granted through the owner role. ## Dependency Requires datum-cloud/milo#532 to be merged and deployed so that the `iam-organization-admin` role exists in `milo-system`. ## Test plan - [ ] Verify the owner role can still manage groups, policybindings, and userinvitations within an organization - [ ] Verify the owner role no longer grants access to platform-level IAM resources (protectedresources, users) 🤖 Generated with [Claude Code](https://claude.com/claude-code)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The platform
iam-adminrole includes permissions for platform-level resources —protectedresourcesandusers— that have no Organization parent and don't belong in the Organization resource hierarchy. When this role is granted at the organization level it gives access to platform-wide resources, which is broader than intended.This PR introduces three new roles scoped strictly to resources that have
Organizationas a parent:iam-organization-viewer: Read access togroups,groupmemberships,userinvitations, andpolicybindingsiam-organization-editor: Inherits viewer; adds create/update/patch/delete on the same resourcesiam-organization-admin: Inherits editor; acts as the org-level IAM admin roleThese roles intentionally exclude:
iam.miloapis.com/users.*— platform resource (no org parent)iam.miloapis.com/protectedresources.*— platform resource (no org parent)iam.miloapis.com/roles.*— scoped toService, notOrganizationTest plan
iam-organization-adminto a user on an organization and confirm they can manage groups/policybindings but cannot access platform-level IAM resourcesiam-organization-viewergrants read-only access as expected🤖 Generated with Claude Code