fix: add watch verb support for user invitations#533
Merged
yahyafakhroji merged 1 commit intomainfrom Mar 24, 2026
Merged
Conversation
The portal's real-time notification system uses K8s Watch API to stream invitation updates via SSE, but watch requests fail with 403 Forbidden because the iam-user-self-manage role only grants get and list verbs on userinvitations. - Add userinvitations.watch permission to iam-user-self-manage role - Extend UserUserInvitationListConstraintDecorator to scope watch requests with the authenticated user's field selector, matching existing list behavior. Without this, watch requests would bypass user-scoping. - Add test cases for watch verb mirroring existing list test coverage
Contributor
scotwells
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
iam.miloapis.com/userinvitations.watchpermission to theiam-user-self-manageRBAC role, enabling real-time watch streams for user invitationsUserUserInvitationListConstraintDecoratorfilter to apply user-scoping field selectors towatchrequests (previously only handledlist), preventing users from watching other users' invitations