feat: add MachineAccount support to PolicyBinding subjects with mandatory namespace validation#552
Conversation
…tory namespace validation
|
Aren't machine keys cluster-scoped resources? |
|
@scotwells MachineAccounts are namespaced resources https://github.com/datum-cloud/milo/blob/main/pkg/apis/iam/v1alpha1/machineaccount_types.go |
|
Is that by design? Their access is granted across the entire project so it's odd they would be namespaced. |
|
@scotwells Is this way by design. That type was introduced 10 months ago. Do you want the MachineAccount type to be updated to be cluster scoped? |
|
I think cluster-scoped would make more sense right now given their access is granted across the entire project. We can introduce a namespaced equivalent if the use-case comes up. |
|
@scotwells I'm doing the changes now. Do you think that I would face issues with the already created MachineAccounts in staging? |
|
@JoseSzycho they may disappear, unsure how the storage layer would like that. |
…nding CRD and documentation
Related to: