fix(iam): include PlatformAccessRejection in CRD kustomization; drop dead Denial CRD#580
Merged
zachsmith1 merged 1 commit intomainfrom Apr 28, 2026
Merged
Conversation
Contributor
📝 Documentation AnalysisJoggr found 1 outdated docs in the pull request. AutofixJoggr opened 1 pull request(s) to fix the outdated docs. Outdated
|
zachsmith1
force-pushed
the
fix/iam-kustomization-missing-crds
branch
from
57b7575 to
d987811
Compare
zachsmith1
changed the title
…dead Denial CRD Two related fixes to config/crd/bases/iam: 1. Add the missing iam.miloapis.com_platformaccessrejections.yaml entry to kustomization.yaml. PlatformAccessRejection was introduced in 41e0bec alongside PlatformAccessApproval (the commit message reads "introduce platform access approval, rejection, and invitation resources"), but only the approval entry made it into kustomization.yaml. PAR has 120 Go references with a real controller and webhook, so it should be in the kustomization alongside PAA. 2. Delete the dead iam.miloapis.com_platformaccessdenials.yaml CRD manifest. PlatformAccessDenial has zero references anywhere in the milo Go codebase — no type, no controller, no webhook. It was an orphaned controller-gen artifact. Regenerated docs/api/iam.md to drop the corresponding sections.
zachsmith1
force-pushed
the
fix/iam-kustomization-missing-crds
branch
from
d987811 to
09366e0
Compare
zachsmith1
changed the title
scotwells
approved these changes
Apr 28, 2026
zachsmith1
added a commit
to datum-cloud/fraud
that referenced
this pull request
Apr 28, 2026
datum-cloud/milo#580 is merged; the iam CRD kustomization on milo main now includes platformaccessrejections.yaml, so install-milo-crds no longer needs to fetch it via a separate raw-URL apply.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two related fixes to
config/crd/bases/iam:1. Add missing
PlatformAccessRejectionentry to the kustomizationPlatformAccessRejectionwas introduced in 41e0bec alongsidePlatformAccessApproval(the commit message reads "introduce platform access approval, rejection, and invitation resources"), but the kustomization update in that commit only added the approval entry. The rejection YAML, Go type, controller, and webhook were all created in the same commit — only the kustomization line was missed.PAR is a real, in-use type:
internal/webhooks/iam/v1alpha1/platformaccessarejection_webhook.gouserinvitation_controller.go2. Delete dead
PlatformAccessDenialCRD manifest + regenerated docsiam.miloapis.com_platformaccessdenials.yamlexists in the directory butPlatformAccessDenialhas zero references anywhere else in the milo codebase — no Go type, no controller, no webhook. It was an orphaned controller-gen artifact. Removed and regenerateddocs/api/iam.mdto drop the corresponding sections.Test plan
kubectl kustomize config/crd/bases/iambuilds cleanly and now produces 13 CRDs (was 12; PAA + 11 others; now PAA + PAR + 11 others; Denial removed entirely).PlatformAccessDenial/platformaccessdenialafter the deletion: zero remaining references.