chore(identity): drop unused location, browser, os SessionStatus fields#585
Merged
mattdjenkinson merged 1 commit intomainfrom Apr 28, 2026
Merged
Conversation
…fields Session enrichment now happens in the GraphQL gateway, which fetches sessions from this API and adds geolocation + parsed user-agent to its own ExtendedSession output. The identity API surface no longer needs its own derived-data fields — they were never populated by the auth provider, so leaving them in place would only mislead API consumers. Keep ip, fingerprintID, lastUpdatedAt, and userAgent — those are raw fields the auth provider does populate and the gateway reads to do enrichment. zz_generated.openapi.go regenerated via task generate:openapi:identity. docs/api/identity.md edited by hand (this file is hand-maintained because config/crd/bases/identity/ has no CRD YAMLs).
Contributor
📝 Documentation AnalysisJoggr found 1 outdated docs in the pull request. AutofixNo autofixes were applied. Outdated
|
scotwells
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
location,browser, andosfromSessionStatus(added in feat: add user agent field and updatedAt to session endpoint #534).ip,fingerprintID,lastUpdatedAt, anduserAgent— those are the raw fields the auth provider actually populates.zz_generated.openapi.govia `task generate:openapi:identity`.docs/api/identity.mdto remove the three rows from the SessionStatus table (this file is hand-maintained becauseconfig/crd/bases/identity/is empty).Why
The session-enrichment topology has been re-aligned: the GraphQL gateway now fetches sessions from this API and produces its own
ExtendedSessiontype with geolocation and parsed user-agent attached. Theauth-provider-zitadelapiserver only writes raw values, so these three derived-data fields onSessionStatusare never populated. Leaving them in place would suggest the API surfaces data it doesn't actually carry.Companion PRs
datum-cloud/auth-provider-zitadel#81— corrected to expose raw IP / fingerprint / lastUpdatedAt / userAgent only (no enrichment).datum-cloud/graphql-gateway— new sessions resolver coming next.datum-cloud/infra#2268— auth-provider gateway-call wiring removed; gateway-side MaxMind plumbing retained.Test plan