rename: machine accounts → service accounts in config#586
Merged
kevwilliams merged 7 commits intomainfrom Apr 29, 2026
Merged
Conversation
Renames all role, protected resource, resource metrics, audit policy, and activity policy config files from machineaccount/machineaccountkeys to serviceaccount/serviceaccountkeys to match the IAM API rename. Also updates the apiserver deployment flag names from --machineaccountkeys-provider-* to --serviceaccountkeys-provider-*.
Contributor
zachsmith1
previously approved these changes
Apr 29, 2026
## ✨ Autofixed 1 outdated doc(s) This pull was automatically generated by Joggr to fix 1 outdated doc(s) due to code changes in pull #586 ### Fixed docs The following docs were fixed: - `docs/api/iam.md`: The MachineAccount resource has been renamed to ServiceAccount at the API, manifest, and RBAC levels. The documentation is updated to consistently reference 'ServiceAccount' throughout, guaranteeing that users reference the correct resource going forward. ### How to fix To fix the docs, you can either: 1. Merge this pull request into your pull request to fix the docs 2. Wait for your pull request to be merged and then merge this pull request into your base branch --- Powered by [Joggr](https://joggr.ai?utm_source=gh&utm_medium=gh&utm_campaign=ghapr&utm_id=ghapr) - The documentation assistant for your codebase.
|
|
scotwells
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
iam-machine-accounts-*/identity-machine-account-keys-*toiam-service-accounts-*/identity-service-account-keys-*machineaccounts.*/machineaccountkeys.*toserviceaccounts.*/serviceaccountkeys.*iam-editorandiam-vieweraggregate roles to referenceserviceaccountspermissionsiam.miloapis.com-machineaccount→iam.miloapis.com-serviceaccount, etc.)milo_machine_accounts→milo_service_accounts)serviceaccountkeysinstead ofmachineaccountkeysServiceAccountresource kind--serviceaccountkeys-provider-*Without this PR, users get a 403 when trying to list/create service accounts because the RBAC permission
iam.miloapis.com/serviceaccounts.listdoesn't exist yet — onlymachineaccounts.listwas defined.Test plan
iam-vieweroriam-editorrole can list service accounts after milo picks up these config changesiam-machine-accounts-*roles are deleted from the cluster (or coexist during transition)