Skip to content

fix: forward field selector to sessions backend #590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zachsmith1 merged 1 commit into from
Apr 30, 2026
+13 −2
Merged

fix: forward field selector to sessions backend #590

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions internal/apiserver/identity/sessions/rest.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,20 @@ func (r *REST) List(ctx context.Context, opts *metainternalversion.ListOptions)
uid = u.GetUID()
groups = u.GetGroups()
}
logger.V(4).Info("Listing sessions", "username", username, "uid", uid, "groups", groups)
// ignore selectors; self-scoped list delegated to provider
// Forward the caller's selectors to the backend so cross-user lookups
// (e.g. status.userUID=<uid>) reach the auth-provider-zitadel REST
// handler. The handler runs its own SAR check against milo using the
// caller identity preserved via X-Remote-* headers in DynamicProvider.
lo := metav1.ListOptions{}
if opts != nil {
if opts.FieldSelector != nil {
lo.FieldSelector = opts.FieldSelector.String()
}
if opts.LabelSelector != nil {
lo.LabelSelector = opts.LabelSelector.String()
}
}
logger.V(4).Info("Listing sessions", "username", username, "uid", uid, "groups", groups, "fieldSelector", lo.FieldSelector, "labelSelector", lo.LabelSelector)
res, err := r.backend.ListSessions(ctx, u, &lo)
if err != nil {
logger.Error(err, "List sessions failed")
Expand Down
Loading