fix: wait for TLS certificates before enabling WAF#107
Merged
Conversation
scotwells
requested review from
JoseSzycho,
OscarLlamas6,
cc-datum,
drewr,
ecv,
kevwilliams and
zachsmith1
When a TrafficProtectionPolicy targets a Gateway with HTTPS listeners, the EnvoyPatchPolicy uses JSONPath selectors to patch the route configuration. However, if the TLS certificate isn't ready yet, Envoy Gateway won't materialize the filter_chains for the HTTPS listener, causing the JSONPath selectors to fail with "ResourceNotFound" errors. This resulted in EnvoyPatchPolicies stuck in a non-programmed state with errors like: "Unable to find xds resources: type.googleapis.com/envoy.config.route.v3.RouteConfiguration/ns-.../gateway/https" The fix adds certificate readiness verification before creating EnvoyPatchPolicies. When certificates are pending, the reconciler: - Sets Accepted=False with reason "WaitingForCertificates" - Lists the pending certificate names in the status message A watch on downstream Certificate resources triggers reconciliation when certificates become ready. Note: This is a mitigation. Ideally, WAF should be enabled on HTTP listeners independently of HTTPS certificate provisioning status. Future work should decouple HTTP and HTTPS listener patching so traffic protection can be applied to HTTP listeners immediately while waiting for certificates.
scotwells
force-pushed
the
fix/tpp-certificate-readiness
branch
from
e3d1382 to
cb946ff
Compare
|
Hell yeah! |
kevwilliams
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a TrafficProtectionPolicy targets a Gateway with HTTPS listeners, the EnvoyPatchPolicy uses JSONPath selectors to patch the route configuration. However, if the TLS certificate isn't ready yet, Envoy Gateway won't materialize the
filter_chainsfor the HTTPS listener, causing the JSONPath selectors to fail with "ResourceNotFound" errors.This resulted in EnvoyPatchPolicies stuck in a non-programmed state with errors like:
The fix adds certificate readiness verification before creating EnvoyPatchPolicies. When certificates are pending, the reconciler:
Accepted=Falsewith reason WaitingForCertificatesA watch on downstream Certificate resources triggers immediate reconciliation when certificates become ready, ensuring minimal delay once TLS is provisioned.
Note
This is a mitigation.
Ideally, WAF should be enabled on HTTP listeners independently of HTTPS certificate provisioning status. Future work should decouple HTTP and HTTPS listener patching so traffic protection can be applied to HTTP listeners immediately while waiting for certificates.