Update canonicalHostname field on proxy status#125
Merged
mattdjenkinson merged 4 commits intomainfrom Apr 9, 2026
Merged
Conversation
scotwells
previously approved these changes
Mar 11, 2026
Contributor
|
@mattdjenkinson i dont think this will work with the new words based default hostname |
Contributor
|
or we might need to look into backwards compatibility a bit. for the other PR, I at least made it respect the old route names but it might need to looking into. or maybe just peak into the gateway listeners section and default-https will be there |
Contributor
|
@mattdjenkinson is this needed anymore or did one of my previous PRs fix it? |
Contributor
Author
|
@zachsmith1 yeah we'll still need this. Why wouldn't it work with the new hostnames? |
Contributor
Author
It's working in staging! |
zachsmith1
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need this field in the UI so we can ensure we always show the Datum provided hostname.