Merged
Conversation
24 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening this here since @joshlreese fork wouldn't build the image. Ref: #84
Summary
Defines CRDs for ConnectorClasses, Connectors, and ConnectorAdvertisements. These have been placed in the
v1alpha1group and NOT thev1alphagroup to align with goals on moving away fromv1alpha.The definition of capabilities has been slightly adjusted to have a
Disabledfield instead of anEnabledfield, and to use CamelCase for capability names. Existence of a capability in the spec will imply that it is expected to be enabled, which aligns with best practices on boolean zero values. I’ve also omitted theleaseReffield from the status of a Connector, as it will be required to have a matching name anyways. I'll have a separate PR for updating the enhancement to align with these changes.See: https://github.com/datum-cloud/enhancements/tree/main/enhancements/networking/connectors/initial-proposal
Other
I have some local changes with a shell script that leverages the kubectl-validate tool to enable defining tests for CRD validation, including CEL expressions. I'll provide that in a separate PR once I get it to a place that I think is useful. The JSON output of the tool can be used to build specific violation assertions, which my current script doesn't leverage yet.