feat: add controller to delete errored ACME challenges#98
Merged
Conversation
Add ChallengeReconciler to automatically delete cert-manager Challenge resources that enter an "errored" state for Gateway-related certificates. This triggers cert-manager to create a new challenge and retry the ACME verification process. The controller: - Watches cert-manager Challenge resources - Deletes challenges in "errored" state for issuers in ClusterIssuerMap - Deletes challenges for namespace-scoped Issuers in per-gateway mode - Is enabled by default via DeleteErroredChallenges config option Closes #94
scotwells
requested review from
JoseSzycho,
OscarLlamas6,
cc-datum,
drewr,
ecv and
zachsmith1
ecv
previously approved these changes
Jan 26, 2026
zachsmith1
previously approved these changes
Jan 26, 2026
| } | ||
|
|
||
| // Check if this challenge is for a Gateway-related issuer | ||
| if !r.isGatewayRelatedIssuer(challenge.Spec.IssuerRef) { |
Contributor
There was a problem hiding this comment.
since this is only for gateway related issuers, does it make sense to watch and reconcile only those in setupwithmanager? that way if something is in the reconcile loop we know we should be operating on it. might save some non-relevant reconciles as well
Contributor
Author
There was a problem hiding this comment.
@zachsmith1 good call, added a predicate filter in 0f5510f.
Ensures that we only reconcile challenges if they are for one of the cluster issuers used by the network services operator.
zachsmith1
approved these changes
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add ChallengeReconciler to automatically delete cert-manager Challenge resources that enter an "errored" state for Gateway-related certificates. This triggers cert-manager to create a new challenge and retry the ACME verification process.
The controller:
Closes #94