refactor: verify the index exists instead of relaying in string comparison#60
Merged
JoseSzycho merged 1 commit intomainfrom Mar 5, 2026
Merged
refactor: verify the index exists instead of relaying in string comparison#60JoseSzycho merged 1 commit intomainfrom
JoseSzycho merged 1 commit intomainfrom
Conversation
scotwells
approved these changes
Mar 5, 2026
github-project-automation
bot
moved this from Backlog
to Done
in Searching Resources in Milo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the meilisearchSDK to eliminate the use of string comparison for determining the existence of an index.
Additionally, the ResourceIndexPolicy finalizer is updated to utilize the new, improved SDK. Consequently, the finalizer can now complete even if the index does not exist.