feat: index all resources when no conditions are configured#84
Merged
JoseSzycho merged 2 commits intomainfrom Apr 27, 2026
Merged
feat: index all resources when no conditions are configured#84JoseSzycho merged 2 commits intomainfrom
JoseSzycho merged 2 commits intomainfrom
Conversation
When a ResourceIndexPolicy has no conditions, resources of the target type are now indexed unconditionally rather than silently skipped. Removes the MinItems=1 validation constraint on conditions and short-circuits the evaluator to set Matched=true when the conditions map is empty. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
scotwells
approved these changes
Apr 27, 2026
github-project-automation
Bot
moved this from Backlog
to Done
in Searching Resources in Milo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
+kubebuilder:validation:MinItems=1fromConditionsfield, making it optionalMatched=truewhen no conditions are present, so all resources of the target type are indexed unconditionallyConditionsto clarify the no-conditions behaviorevaluator.goTest plan
ResourceIndexPolicywith noconditionsfield and verify resources of the target type are indexedResourceIndexPolicywith conditions and verify existing OR-semantics still applykubectl applyaccepts a policy with an empty/absentconditionsfield (validation no longer requiresMinItems=1)🤖 Generated with Claude Code
Related to: datum-cloud/datum#216 (comment)