Skip to content

refactor vocab#54

Merged
davanstrien merged 1 commit intomainfrom
refactor-vocab
Apr 23, 2021
Merged

refactor vocab#54
davanstrien merged 1 commit intomainfrom
refactor-vocab

Conversation

@davanstrien
Copy link
Owner

No description provided.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Apr 23, 2021

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.17%.

Quality metrics Before After Change
Complexity 4.89 ⭐ 4.77 ⭐ -0.12 👍
Method Length 54.27 ⭐ 54.07 ⭐ -0.20 👍
Working memory 7.45 🙂 7.45 🙂 0.00
Quality 73.49% 🙂 73.66% 🙂 0.17% 👍
Other metrics Before After Change
Lines 227 225 -2
Changed files Quality Before Quality After Quality Change
src/flyswot/models.py 73.49% 🙂 73.66% 🙂 0.17% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
src/flyswot/models.py download_model 2 ⭐ 137 😞 12 😞 58.72% 🙂 Try splitting into smaller methods. Extract out complex expressions
src/flyswot/models.py vocab 8 ⭐ 93 🙂 10 😞 62.13% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

@davanstrien davanstrien merged commit e38fe93 into main Apr 23, 2021
@davanstrien davanstrien deleted the refactor-vocab branch April 23, 2021 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant