Skip to content

small mypy fixes#73

Merged
davanstrien merged 2 commits intomainfrom
mypy
Apr 28, 2021
Merged

small mypy fixes#73
davanstrien merged 2 commits intomainfrom
mypy

Conversation

@davanstrien
Copy link
Owner

No description provided.

@davanstrien davanstrien added the bug Something isn't working label Apr 28, 2021
@davanstrien davanstrien self-assigned this Apr 28, 2021
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Apr 28, 2021

Sourcery Code Quality Report

Merging this PR leaves code quality unchanged.

Quality metrics Before After Change
Complexity 0.96 ⭐ 0.96 ⭐ 0.00
Method Length 40.50 ⭐ 40.50 ⭐ 0.00
Working memory 8.62 🙂 8.62 🙂 0.00
Quality 75.73% 75.73% 0.00%
Other metrics Before After Change
Lines 197 197 0
Changed files Quality Before Quality After Quality Change
src/flyswot/inference.py 75.73% ⭐ 75.73% ⭐ 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
src/flyswot/inference.py predict_directory 1 ⭐ 193 😞 15 😞 50.07% 🙂 Try splitting into smaller methods. Extract out complex expressions
src/flyswot/inference.py print_table 4 ⭐ 107 🙂 10 😞 64.08% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

@davanstrien davanstrien merged commit 0eb4c65 into main Apr 28, 2021
@davanstrien davanstrien deleted the mypy branch April 28, 2021 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant