Specify a cmake export set#268
Merged
davea42 merged 1 commit intodavea42:mainfrom Nov 21, 2024
Merged
Conversation
Owner
|
It's not causing any problems in my cmake builds. |
Contributor
Author
|
Thanks Dave! It has worked for me as well but I guess this only causes problems when a target tries to define an |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I got an issue on my library cpptrace about specifying an export set in cmake jeremy-rifkin/cpptrace#189. It looks like it's important to both
install(EXPORT)andexport()in cmake.In order to patch this in my repository, it looks like libdwarf needs to define an export set too. This PR implements this. Tested locally and things seem ok.