Fixes #171 — Unescaped titles in bookmarks causing braindrop to crash #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuarkaliyev23
changed the title
davep
added
Bug
davep
reviewed
Sep 3, 2025
| "collection", | ||
| f"{PUBLIC_ICON if self.data.collection(self.raindrop.collection).public else PRIVATE_ICON}" | ||
| f" {self.data.collection(self.raindrop.collection).title}", | ||
| f" {escape(self.data.collection(self.raindrop.collection).title)}", |
Owner
There was a problem hiding this comment.
As noted in a comment in #171 this wouldn't seem to actually address what you think is the cause of the problem. Let's keep this here anyway -- it's sensible that this does get escaped and it always should have been -- but I think we might want to add a couple more calls to escape elsewhere too, depending on what problem you're actually seeing and what the actual cause is.
Owner
|
As it turns out, this doesn't directly address #171 in that this adds escaping to the collection title, not a bookmark title. As it stands this is still a good thing to do anyway so I'll merge this in. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding escape in title parsing