Skip to content

Fixes #171 — Unescaped titles in bookmarks causing braindrop to crash #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 4, 2025
Merged

Fixes #171 — Unescaped titles in bookmarks causing braindrop to crash #172

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/braindrop/app/widgets/raindrop_details.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,7 @@ def _refresh_display(self) -> None:
self._set(
"collection",
f"{PUBLIC_ICON if self.data.collection(self.raindrop.collection).public else PRIVATE_ICON}"
f" {self.data.collection(self.raindrop.collection).title}",
f" {escape(self.data.collection(self.raindrop.collection).title)}",
Copy link
Owner

@davep davep Sep 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As noted in a comment in #171 this wouldn't seem to actually address what you think is the cause of the problem. Let's keep this here anyway -- it's sensible that this does get escaped and it always should have been -- but I think we might want to add a couple more calls to escape elsewhere too, depending on what problem you're actually seeing and what the actual cause is.

)
self._set("note", self.raindrop.note, Markdown)
self._set(
Expand Down