Fix UnboundLocalError in training thread exception handlers#2
Merged
davepl merged 2 commits intoSeptAvgLevelfrom Sep 15, 2025
Merged
Fix UnboundLocalError in training thread exception handlers#2davepl merged 2 commits intoSeptAvgLevelfrom
davepl merged 2 commits intoSeptAvgLevelfrom
Conversation
davepl
approved these changes
Sep 15, 2025
Copilot
AI
changed the title
[WIP] Remember we don't want to protect AGAINST this case, it's an assert. We want to FIX whatever issue is getting us into that situation, not by masking or or patching, but by understanding and fixing the underlying issue.
Fix UnboundLocalError in training thread exception handlers
Sep 15, 2025
davepl
added a commit
that referenced
this pull request
Feb 21, 2026
[WIP] Remember we don't want to protect AGAINST this case, it's an assert. We want to FIX whatever issue is getting us into that situation, not by masking or or patching, but by understanding and fixing the underlying issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Training threads were failing with two related errors:
'DQNAgent' object has no attribute 'train_step'UnboundLocalError: cannot access local variable 'traceback' where it is not associated with a valueThe root cause was redundant local
import tracebackstatements inside exception handlers in thebackground_trainandtrain_stepmethods.Root Cause Analysis
The issue occurred in two locations in
aimodel.py:The module already imports
tracebackat the top level (line 66), making these local imports redundant and potentially problematic in threading contexts where the local import can cause variable scoping issues.Solution
Removed the redundant local
import tracebackstatements and use the existing module-level import:Testing
train_stepmethod exists and is callableThe training system now operates correctly with proper exception handling and no thread-related import issues.
Created from VS Code via the GitHub Pull Request extension.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.