Merged
Conversation
…on calls Eliminates all 28 Effect.t constructors and the two large effect handlers (run_deep, run_deep_source). Combinators now call handler helpers directly via DLS-based state, removing continuation capture/resume overhead. Architecture: - Domain.DLS.new_key for per-domain parser state - Direct function calls instead of Effect.perform + handler dispatch - Exceptions for backtracking (or_, look_ahead, many) - Same handler helpers reused verbatim Results vs effects version (main branch): - json_fused: 6.05M -> 6.09M (~same, handler helpers dominate) - json_generic: 1.30M -> 1.90M (+46%, effect overhead removed) - csv_generic: 1.63M -> 2.39M (+47%) - arith_fused: 8.53M -> 10.0M (+17%, fold_left uses many/or_) - arith_generic: 1.04M -> 1.83M (+75%) - Minor alloc: ~30-40% reduction across all benchmarks Generic Parseff now beats standard Angstrom on all benchmarks. All 328 tests pass. Public API (.mli) unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.