Skip to content

Basic output display #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
May 6, 2024
Merged

Basic output display #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
2bf1a46
Work on outputs
davidagold May 5, 2024
00e9248
Work
davidagold May 5, 2024
eea3db9
Produce cell output buffers
davidagold May 5, 2024
335ba10
Bugfix, but we're still seeing no outputs
davidagold May 5, 2024
730bb3b
Better way to do syntax highlighting
davidagold May 5, 2024
f06d92c
Didn't mean to comment that
davidagold May 5, 2024
82a500b
Clean up a bit
davidagold May 5, 2024
627ed38
(Some) Output cells print
davidagold May 6, 2024
c3a0e3c
Remove commented code
davidagold May 6, 2024
6ffb261
Aesthetics
davidagold May 6, 2024
b5170c7
Error forwarding utility and cleanup
davidagold May 6, 2024
ee4bcb4
Simple outputs display
davidagold May 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion crates/language/src/language.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1270,7 +1270,6 @@ impl Language {
let tree = grammar.parse_text(text, None);
let captures =
SyntaxSnapshot::single_tree_captures(range.clone(), text, &tree, self, |grammar| {
log::info!("Did capture");
grammar.highlights_query.as_ref()
});
let highlight_maps = vec![grammar.highlight_map()];
Expand Down
1 change: 1 addition & 0 deletions crates/notebook/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ async-compat = { version = "0.2.1", "optional" = true }
collections.workspace = true
command_palette_hooks.workspace = true
editor.workspace = true
futures.workspace = true
gpui.workspace = true
itertools.workspace = true
language.workspace = true
Expand Down
Loading