Skip to content

support tls extension#22

Merged
davidbrochart merged 5 commits into
davidbrochart:mainfrom
leon1995:feature/tls-extension
Oct 11, 2025
Merged

support tls extension#22
davidbrochart merged 5 commits into
davidbrochart:mainfrom
leon1995:feature/tls-extension

Conversation

@leon1995
Copy link
Copy Markdown
Contributor

@leon1995 leon1995 commented Oct 9, 2025

closes #21

Copy link
Copy Markdown
Owner

@davidbrochart davidbrochart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot review that code, since I don't know much about TLS. Could you tell a bit more about it, was it copied from another project or something?
Also, I see that you made some changes in quic.py, but do you know that anycorn doesn't support HTTP/3?

Comment thread README.md Outdated
Anycorn is a fork of [Hypercorn](https://github.com/pgjones/hypercorn) where `asyncio` and
[Trio](https://trio.readthedocs.io) compatibility is delegated to AnyIO, instead of having a
separate code base for each. Anycorn forked from version 0.16.0 of Hypercorn.
separate code base for each. Anycorn forked from version 0.16.0 of Hypercorn that supports [tls extension](https://asgi.readthedocs.io/en/latest/specs/tls.html).
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean that Hypercorn v0.16.0 supports TLS extension? The sentence sounds like it.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed that in the next push

@leon1995
Copy link
Copy Markdown
Contributor Author

I cannot review that code, since I don't know much about TLS. Could you tell a bit more about it, was it copied from another project or something? Also, I see that you made some changes in quic.py, but do you know that anycorn doesn't support HTTP/3?

Ill add more documentation to the links. I did not copy that from another project. I mainly followed the explanation in https://asgi.readthedocs.io/en/latest/specs/tls.html.

I tried to keep the interfaces in sync, thats why I edited quic.py

Copy link
Copy Markdown
Owner

@davidbrochart davidbrochart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @leon1995.

@davidbrochart davidbrochart merged commit 75adcaf into davidbrochart:main Oct 11, 2025
27 checks passed
@leon1995 leon1995 deleted the feature/tls-extension branch October 14, 2025 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

get certificate from client peer

2 participants