Skip to content

Update#27

Merged
davidbrochart merged 17 commits into
davidbrochart:mainfrom
leon1995:update
Mar 16, 2026
Merged

Update#27
davidbrochart merged 17 commits into
davidbrochart:mainfrom
leon1995:update

Conversation

@leon1995
Copy link
Copy Markdown
Contributor

No description provided.

@leon1995
Copy link
Copy Markdown
Contributor Author

what about doing automated github releases when publishing a package to pypi? at least for me its kinda confusing that there is no github release for the current 0.18.2

@davidbrochart
Copy link
Copy Markdown
Owner

I usually use this kind of workflow. It publishes to PyPI when I push a version tag, and create a GitHub release by looking at the changelog. I can do that in another PR.

@leon1995
Copy link
Copy Markdown
Contributor Author

I usually use this kind of workflow. It publishes to PyPI when I push a version tag, and create a GitHub release by looking at the changelog. I can do that in another PR.

yeah thats a good idea. This pr is already huge

Comment thread pyproject.toml
name = "anycorn"
dynamic = ["version"]
requires-python = ">=3.9"
version = "0.0.0"
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
version = "0.0.0"
version = "0.18.2"

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

version will be set during the publish step where it is taken from the tag that has been pushed. no need to set the version manually anymore

@davidbrochart
Copy link
Copy Markdown
Owner

Thanks @leon1995.

@davidbrochart davidbrochart merged commit 6022c6a into davidbrochart:main Mar 16, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants