Add min_candidate_length parameter to PhoneNumberMatcher #319
+41
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| candidate) | ||
| candidate_len = len(candidate) | ||
|
|
||
| if candidate_len >= self._min_candidate_length: |
Owner
There was a problem hiding this comment.
Please could we add a comment here to indicate that the Python code is diverging from the upstream code.
| def __init__(self, text, region, | ||
| leniency=Leniency.VALID, max_tries=65535): | ||
| leniency=Leniency.VALID, max_tries=65535, | ||
| min_candidate_length=1): |
Owner
There was a problem hiding this comment.
I'm not normally keen on the Python port having divergences from the upstream Java code, but this looks useful and the default value for the argument means that it's back-compatible with any existing client use.
Please could you add some unit tests for it, and mark them as Python-specific?
Contributor
Author
|
Thanks, I added the comment and unit tests. |
daviddrysdale
approved these changes
Jan 16, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some large and "bad" inputs, like whole HTML page, the regex produces a lot of matches that are just one or two digits, which then just get filtered out.
For my particular use-case, when I set the minimum to 4 digits (I don't care about special short numbers), I get about 50% speed-up on that particular input.