Feature to preserve inline comment spacing#129
Merged
davidvarga merged 1 commit intodavidvarga:masterfrom Apr 17, 2025
Merged
Conversation
Contributor
Author
|
Okay, I did actually find a way of replacing tabs with spaces correctly, but it is quite a beast... |
|
I have the same issue. Would love to see this merged. |
Owner
|
Thanks for the PR, merged it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some cases (for me at least) it makes sense to preserve the spacing for inline comments. Consider the following snippet for example:
The formatting is nice and tidy, however after applying the normal formatFile to it, it becomes this, which is much less readable imo:
Therefore, I added a new special rule
PreserveInlineCommentSpacingto keep the original spacing in these cases.The downside of the solution is that the type of spacing (tabs, spaces) used by the user will also be preserved. I don't really see an easy way to change that, as tabs can represent a variable number of spaces.