Add an option to force static runtime#1847
Merged
Merged
Conversation
Owner
|
This seems like the wrong solution. What happens if you use the latest copy of dlib from github, without any modifications? |
Contributor
Author
|
@davisking I get exactly the same issue with master. |
Owner
|
Oops, the build settings weren't quite what they should have been. I just pushed a change, try the latest code now. |
Contributor
Author
|
I dont want to rebuild libjpeg; this will eat some CI time and the package will be bigger. |
Owner
|
Well, the change you were proposing will break many other users. Which is how it got to be in the cmake scripts in the first place.
You can make a cmake variable that toggles it if you like though. But it must be on by default.
… On Jul 27, 2019, at 10:04 AM, Julien Schueller ***@***.***> wrote:
I dont want to rebuild libjpeg; this will eat some CI time and the package will be bigger.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Contributor
Author
|
I think I'll manually patch dlib, imho forcing another runtime is a very bad idea in the first place. |
Owner
|
I wouldn't do it if it didn't result in me getting a flood of questions
from people confused about missing visual studio runtime dlls :(
…On Sat, Jul 27, 2019 at 10:29 AM Julien Schueller ***@***.***> wrote:
I think I'll manually patch dlib, imho forcing another runtime is a very
bad idea in the first place.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1847?email_source=notifications&email_token=ABPYFR3FBCY3XSCV5GJ7XMDQBRLTPA5CNFSM4IHJFUBKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD26MO4A#issuecomment-515688304>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABPYFRYCXFQDJWUYRAEIJ4DQBRLTPANCNFSM4IHJFUBA>
.
|
Collaborator
|
Warning: this issue has been inactive for 35 days and will be automatically closed on 2019-09-10 if there is no further activity. If you are waiting for a response but haven't received one it's possible your question is somehow inappropriate. E.g. it is off topic, you didn't follow the issue submission instructions, or your question is easily answerable by reading the FAQ, dlib's official compilation instructions, dlib's API documentation, or a Google search. |
jschueller
changed the title
Contributor
Author
|
@davisking I added an option to toggle it |
Owner
|
Thanks, looks good. |
bkornel
added a commit
to bkornel/dlib
that referenced
this pull request
Sep 18, 2019
* Fixed compiler warnings * Include the Intel MKL's iomp dll in the output folder to reduce confusino for windows users. * Fixed build error in newer clang on OpenBSD. * Fixed constness for lapack functions (davisking#1737) * disable annoying warning * Fixed global_function_search's initialization being wrong if explicitly given an empty list of initial function evaluations. * Suppress compiler warnings * Make things work in visual studio. * fix some pedantic warnings (davisking#1756) * fix some pedantic warnings * remove unneeded assert * more pedantic silencing (davisking#1763) * prevent GCC from complaining about this unused parameter * Even more warning silencing (davisking#1766) These warnings occurred when building the semantic segmentation examples * iEnsures DLIB_FALLTHROUGH macro is only set for GCC>=7 (davisking#1770) * Feature/upgrade libjpeg (davisking#1769) * Upgrades dlib's included libjpeg to version 8d * Overloads load_jpeg to read from memory buffer * Removes "__inline__" define in jconfig, broke VC build * Changes buffer size type to size_t * Adds a comprehensive error message when jpeg loading fails. * Disable use of non-memory based backing store in libjpeg. This fixes libjpeg not being able to open some types of jpeg file. * Stop building parts of libjpeg we don't need. * Add input_grayscale_image_pyramid, issue davisking#354 (davisking#1761) Add input_grayscale_image_pyramid * Added methods for getting keyboard and mouse clicks to image_window's pyhton API. * Fixed pytest broken dependencies * Fix python setup warnings * Revert "Fixed pytest broken dependencies" Apparently pytest is still sort of busted. This reverts commit 5e63d01. * Fix setting a point's y coordinate changes x instead (Python bindings) (davisking#1795) * Add point assignment test * Fix setting points y coordinate changes x instead (issue davisking#1794) * Push all include and link options needed for dlib to pkg-config. We do this by getting them from the same list cmake uses. * Fixed incorrect return type * Fixed grammar in comments * Added missing include * fixed typo in docs * fix mismatch between documentation and implementation (davisking#1835) * Fixed cmake warning * fixing grammar * Fix the CMake BUILDING_PYTHON_IN_MSVC variable not getting picked up where it should. * pybind11: cmake: ignore the check between host-python and cross-compiler (davisking#1848) When dlib is compiling, cmake will compare python architecture and target architecture. So in cross-compiling case, it is irrevelant because host and target architecture often differs. The main problem come from checking python architecture on host and not on target. Here is an error when compiling dlib from x86_64 to arm 32-bit target : ``` Python config failure: Python is 64-bit, chosen compiler is 32-bit ``` So : - Skipping the comparation when cross-compiling is enabled. Signed-off-by: Romain Naour <romain.naour@smile.fr> Signed-off-by: Alexandre PAYEN <alexandre.payen@smile.fr> * Const-correct a LAPACK declaration and add aarch64 as a 64-bit architecture (davisking#1859) * Added aarch64 to list of 64-bit architechtures * Const-corrected declaration of ssyevr * Fix davisking#1849 by calling device_global_buffer() unconditionally (davisking#1862) * Hold on to the CUDA buffer - second try see: davisking#1855 (comment) * Fix davisking#1849 by calling device_global_buffer() unconditionally * Simplified the device_global_buffer() code and API. * don't cast away constness (davisking#1865) * dpoint mutates x-coord in y-property (see davisking#1794) (davisking#1866) * add loss_mean_squared_per_channel (davisking#1863) add loss_mean_squared_per_channel_and_pixel * Clear truth_idxs between samples (davisking#1870) * Clear truth_idxs between samples * Move truth_idxs inside loop body after all * Push to truth_idxs even when the box can't be detected; improve formatting * Add an option to force static runtime (davisking#1847) * dos2unix tell_visual_studio_to_use_static_runtime.cmake * Add an option to force static runtime
nidegen
pushed a commit
to kapanu/dlib
that referenced
this pull request
Sep 23, 2020
* dos2unix tell_visual_studio_to_use_static_runtime.cmake * Add an option to force static runtime
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forcing the static runtime results in undefined symbols in dependencies using another runtime
In general its a bad idea to change the runtime, as cl warns:
Closes #1846