Skip to content

Streaming I/O#71

Merged
davydany merged 22 commits intodavydany:masterfrom
quizzicus:master
Feb 20, 2019
Merged

Streaming I/O#71
davydany merged 22 commits intodavydany:masterfrom
quizzicus:master

Conversation

@quizzicus
Copy link
Copy Markdown
Contributor

No description provided.

davydany
davydany previously approved these changes Feb 19, 2019
Copy link
Copy Markdown
Owner

@davydany davydany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@davydany
Copy link
Copy Markdown
Owner

@quizzicus Looks like some tests are failing. Can you make sure this is not due to your changes?

@quizzicus
Copy link
Copy Markdown
Contributor Author

It is due to my changes. halt_on_nonzero wasn't working right, so I set out to fix that. But now some tests are outdated, which I was going to fix today.

@davydany davydany merged commit c6412f9 into davydany:master Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants