Skip to content

refactor: remove unnecessary methods and improve css export #20

Merged
daybrush merged 15 commits into1.0.0-rcfrom
refactor
Mar 9, 2019
Merged

refactor: remove unnecessary methods and improve css export #20
daybrush merged 15 commits into1.0.0-rcfrom
refactor

Conversation

@daybrush
Copy link
Owner

@daybrush daybrush commented Mar 9, 2019

No description provided.

@coveralls
Copy link

coveralls commented Mar 9, 2019

Pull Request Test Coverage Report for Build 145

  • 349 of 376 (92.82%) changed or added relevant lines in 11 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-1.02%) to 92.528%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Animator.ts 44 46 95.65%
src/presets.ts 12 14 85.71%
src/Scene.ts 41 44 93.18%
src/SceneItem.ts 173 193 89.64%
Files with Coverage Reduction New Missed Lines %
src/SceneItem.ts 1 91.6%
src/utils.ts 3 87.31%
Totals Coverage Status
Change from base Build 143: -1.02%
Covered Lines: 1362
Relevant Lines: 1429

💛 - Coveralls

@daybrush daybrush merged commit 6f0a211 into daybrush:1.0.0-rc Mar 9, 2019
daybrush added a commit that referenced this pull request Mar 26, 2019
* refactor: remove unnecessary methods and improve css export  (#20)

* fix: fix banner

* fix: fix toCSS

* fix: update jsdoc

* fix: State type

* fix: tslint for interface-name

* fix: fix for multi selector

* fix(Animator): fix finish method

* fix: refactoring Scene.js

* fix(SceneItem): fix for array properties

* feat: add setTarget method

* fix: refactoring Scene.js

* refactor: refactor toCSS method

* demo: fix demo src

* test: test getEntries

* demo: fix demo address

* fix: fix for function property value (#21)

* fix: fix update method for ordering (#22)

* fix: fix package script

* fix: fix types

* fix: fix vue-scne for 1.0.0-rc3

* fix: fix react-scenejs for 1.0.0-rc3

* fix: fix ng-scene for 1.0.0-rc3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants