Skip to content

livepeer: Enable network payments#769

Merged
j0sh merged 1 commit intomainfrom
ja/enable-payments
Apr 1, 2026
Merged

livepeer: Enable network payments#769
j0sh merged 1 commit intomainfrom
ja/enable-payments

Conversation

@j0sh
Copy link
Copy Markdown
Contributor

@j0sh j0sh commented Mar 30, 2026

  • Frontend sends api_key down with connect request (already in local storage). This Daydream key authenticates the payment request.

  • Wire the API key through into the Livepeer SDK via start_lv2v

  • Add knobs to configure the payment signer via LIVEPEER_SIGNER env var. If unset, default to signer.daydream.live. Disable with a falsy value.

  • Send payments every 10s

  • Smaller doc updates

@j0sh j0sh requested review from emranemran and leszko March 30, 2026 23:15
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 30, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 0d3eb613-a754-4d3f-9de3-3687c199a5af

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ja/enable-payments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 30, 2026

🚀 fal.ai Preview Deployment

App ID daydream/scope-pr-769--preview
WebSocket wss://fal.run/daydream/scope-pr-769--preview/ws
Commit 1e6588f

Livepeer Runner

App ID daydream/scope-livepeer-pr-769--preview
WebSocket wss://fal.run/daydream/scope-livepeer-pr-769--preview/ws
Auth private

Testing

Connect to this preview deployment by running this on your branch:

uv run build && SCOPE_CLOUD_APP_ID="daydream/scope-pr-769--preview/ws" uv run daydream-scope

Livepeer mode:

SCOPE_CLOUD_MODE=livepeer SCOPE_CLOUD_APP_ID="daydream/scope-livepeer-pr-769--preview/ws" uv run daydream-scope

🧪 E2E tests will run automatically against this deployment.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 30, 2026

❌ E2E Tests failed

Status failed
fal App daydream/scope-pr-769--preview
Run View logs

Test Artifacts

Check the workflow run for screenshots, traces, and failure details.

@j0sh j0sh force-pushed the ja/enable-payments branch from fced82b to 6217366 Compare March 31, 2026 06:02
* Frontend sends `api_key` down with connect request (already in local
  storage). This Daydream key authenticates the payment request.

* Wire the API key through into the Livepeer SDK via start_lv2v

* Add knobs to configure the payment signer via LIVEPEER_SIGNER env var.
  If unset, default to `signer.daydream.live`. Disable with a falsy value.

* Send payments every 10s

* Smaller doc updates

Signed-off-by: Josh Allmann <joshua.allmann@gmail.com>
@j0sh j0sh force-pushed the ja/enable-payments branch from 6217366 to 1e6588f Compare March 31, 2026 06:02
@j0sh j0sh requested a review from seanhanca March 31, 2026 17:59
@emranemran
Copy link
Copy Markdown
Contributor

LGTM - why every 10s for the payment? Is that arbitrary or part of the protocol?

@j0sh
Copy link
Copy Markdown
Contributor Author

j0sh commented Apr 1, 2026

why every 10s for the payment? Is that arbitrary or part of the protocol?

It's arbitrary. Doesn't need to be too often, but shouldn't be foo far apart either. The timing can be tweaked however we like.

@j0sh j0sh merged commit bdedb23 into main Apr 1, 2026
9 of 10 checks passed
@j0sh j0sh deleted the ja/enable-payments branch April 1, 2026 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants