Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🚀 fal.ai Preview Deployment
Livepeer Runner
TestingConnect to this preview deployment by running this on your branch: Livepeer mode: 🧪 E2E tests will run automatically against this deployment. |
❌ E2E Tests failed
Test ArtifactsCheck the workflow run for screenshots, traces, and failure details. |
fced82b to
6217366
Compare
* Frontend sends `api_key` down with connect request (already in local storage). This Daydream key authenticates the payment request. * Wire the API key through into the Livepeer SDK via start_lv2v * Add knobs to configure the payment signer via LIVEPEER_SIGNER env var. If unset, default to `signer.daydream.live`. Disable with a falsy value. * Send payments every 10s * Smaller doc updates Signed-off-by: Josh Allmann <joshua.allmann@gmail.com>
6217366 to
1e6588f
Compare
|
LGTM - why every 10s for the payment? Is that arbitrary or part of the protocol? |
It's arbitrary. Doesn't need to be too often, but shouldn't be foo far apart either. The timing can be tweaked however we like. |
Frontend sends
api_keydown with connect request (already in local storage). This Daydream key authenticates the payment request.Wire the API key through into the Livepeer SDK via start_lv2v
Add knobs to configure the payment signer via LIVEPEER_SIGNER env var. If unset, default to
signer.daydream.live. Disable with a falsy value.Send payments every 10s
Smaller doc updates