Handle TransferEncodingError as graceful network disconnect in media input loop#807
Open
livepeer-tessa wants to merge 2 commits intomainfrom
Open
Handle TransferEncodingError as graceful network disconnect in media input loop#807livepeer-tessa wants to merge 2 commits intomainfrom
livepeer-tessa wants to merge 2 commits intomainfrom
Conversation
added 2 commits
April 2, 2026 06:25
- graph_executor.py: deduplicate fan-in stream edges before queue construction, preferring pipeline-node sources over source-node sources for the same input port; raise a clearer error (with edge details) when two pipeline nodes both target the same port - graph_executor.py: in _validate_edge_ports, include VACE ports for VACEEnabledPipeline instances regardless of static config_class.inputs; gracefully handle PipelineNotAvailableException (pipeline reloading) by logging a warning and skipping port checks for that node - frame_processor.py: in _setup_graph_from_pipeline_ids, only add the last VACEEnabledPipeline to vace_input_video_ids (not all of them), preventing fan-in when a preprocessor like yolo_mask is also a VACEEnabledPipeline Fixes #804 Signed-off-by: livepeer-robot <robot@livepeer.org>
…input loop When an orchestrator truncates the trickle connection mid-stream, aiohttp raises ClientPayloadError (subclass TransferEncodingError). Previously this was caught by the broad 'except Exception' handler and logged at ERROR level, causing noisy logs and unclean teardown. - Catch aiohttp.ClientPayloadError before the generic handler; log at WARNING and let the finally block run the normal media_output.close() path - Suppress ClientConnectorError during media_output.close() (logged at DEBUG) when the orchestrator is already unreachable at teardown time The deeper fix (in livepeer-python-gateway channel_reader.py / trickle_publisher.py) ensures the control channel subscription also terminates cleanly without raising. See: livepeer/livepeer-python-gateway#2 Fixes: #805 Related: #771 Signed-off-by: livepeer-robot <robot@livepeer.org>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
🚀 fal.ai Preview Deployment
Livepeer Runner
TestingConnect to this preview deployment by running this on your branch: Livepeer mode: 🧪 E2E tests will run automatically against this deployment. |
Contributor
❌ E2E Tests failed
Test ArtifactsCheck the workflow run for screenshots, traces, and failure details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #805
What
When an orchestrator goes down or is restarted mid-session, aiohttp raises
ClientPayloadError(specificallyTransferEncodingError: 400) on open trickle connections. Previously:_media_input_loopcaught this in the genericexcept Exceptionand loggedERROR - Media input loop failed: ...JSONLReaderinlivepeer-python-gateway) also errored, loggingERROR - Control channel subscription error: ...ERROR - Trickle DELETE exceptionlogsThis is pure network-level disconnect noise — the session ends regardless, we were just logging it wrong and making the stack trace look like a bug.
Changes
src/scope/cloud/livepeer_app.pyaiohttp.ClientPayloadErrorin_media_input_loopbefore the generic handler → log atWARNINGinstead ofERRORaiohttp.ClientConnectorErrorduringmedia_output.close()→ log atDEBUG(orchestrator already gone)Companion PR in livepeer-python-gateway: livepeer/livepeer-python-gateway#2
channel_reader.py: Same treatment forChannelReaderandJSONLReader— clean return instead ofLivepeerGatewayErrortrickle_publisher.py: DemoteClientConnectorErrorin_run_deletefromERRORtoDEBUGBefore / After
Before:
After:
Related: #771 (same pattern, EOFError on clean disconnect)