fix(e2e): update cloud-streaming test for graph-mode UI redesign#970
Closed
emranemran wants to merge 2 commits intomainfrom
Closed
fix(e2e): update cloud-streaming test for graph-mode UI redesign#970emranemran wants to merge 2 commits intomainfrom
emranemran wants to merge 2 commits intomainfrom
Conversation
The redesign in #886 replaced the streaming-first landing with a Workflow/Perform toggle and removed the "Daydream Scope" heading the test was polling for. The test has been dead since then. Updates: - Wait on the Perform-mode toggle appearing instead of the missing heading - Explicitly switch to Perform mode before the cloud/pipeline/stream steps — default is now Workflow (graph mode) where those controls aren't rendered - Find the cloud button by title attribute (covers all three states: "Connect to cloud", "Connecting to cloud...", "Cloud connected") - Bump the cloud-connect timeout to 180s so fal cold-starts have room - Verify frame flow by polling any <video> element rather than locating the old "Video Output" card wrapper - Stop uses the start-stream-button toggle (PlayOverlay changes role when streaming) with a text-based fallback Verified locally: full flow passes in ~3 minutes against a warm fal deploy with the passthrough pipeline. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Signed-off-by: emranemran <emran.mah@gmail.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
🚀 fal.ai Preview Deployment
Livepeer Runner
Testing Livepeer Mode |
The previous iteration of this test false-positively passed. It polled any <video> for playback, which always finds the local input preview playing even when the browser↔local-scope WebRTC never completes and no frames ever reach the cloud. The result: ClickHouse saw only websocket_connected / pipeline_loaded / websocket_disconnected — nothing that requires a real round-trip through the livepeer runner. Two fixes: 1. Feed the browser a synthetic camera via --use-fake-device-for-media-stream (plus the Camera input toggle in the UI). This lets getUserMedia() succeed and a real WebRTC peer connection between browser and local scope complete end to end, which triggers CloudTrack._start() → LivepeerClient.start_media() and the "start_stream" trickle control message the runner needs. 2. Assert on the video inside the "Video Output" card, not any <video>. That element only renders when a remoteStream is set, so waiting on its visibility and currentTime > 0 is a true round-trip signal. After frames start flowing, idle 15s so stream_heartbeat events (~every 10s on the runner side) have a chance to fire. Verified locally: test passes in ~2.8 min against scope-livepeer-emran with passthrough. Full event set lands in ClickHouse when paired with the parity PR (#969). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Signed-off-by: emranemran <emran.mah@gmail.com>
emranemran
added a commit
that referenced
this pull request
Apr 20, 2026
Rewrite the testing-livepeer-fal-deploy SKILL so the primary recommended path is the Playwright test (folded in from #970 via cherry-pick). It's the only path that exercises the full livepeer trickle round-trip and produces every session-lifecycle Kafka event. Keep test-cloud-connect.sh as a secondary, bash-only smoke test for "did the fal container come up?" / bisecting cloud-connect regressions. Also fix run-app.sh: the previous form tried to inline-prefix env vars via ${VAR:+VAR=$VAR} on a backslash-continued command, which breaks under bash word-splitting ("SCOPE_CLOUD_API_KEY=sk_... command not found"). Switch to `export` + `exec uv run`. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Signed-off-by: emranemran <emran.mah@gmail.com>
6 tasks
Contributor
Author
|
Folded into #962 — the two Playwright commits were cherry-picked onto the tooling branch, and the skill was rewritten to lead with the Playwright path. Closing this PR as superseded. Branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Workflow/Perform redesign (#886) broke the e2e test — the landing page no longer renders a `Daydream Scope` heading and its default view is the graph builder, not the streaming UI. The test has been silently failing since then.
Changes
Verified
Full flow passes against `scope-livepeer-emran` deploy with passthrough pipeline, ~3 min including fal cold-start.
```
✅ Cloud mode toggled on
✅ Cloud connection established
✅ Passthrough model selected
✅ Stream started
✅ Frames flowing
✅ Stream stopped
✅ Cloud streaming test passed
```
Test plan
🤖 Generated with Claude Code