Merged
Conversation
AutofillAgent notifies PasswordAutofillAgent about field value changes made by website's JS, if the fields have password type, or were parsed as username fields. However username fields are not guaranteed to be text inputs at this moment. Fixing the crash by checking this explicitly. Fixed: 380106918 Change-Id: I6377750b935f2609f11569be8c9bcf61841aa12a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6037910 Reviewed-by: Christoph Schwering <schwering@google.com> Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> Auto-Submit: Maria Kazinova <kazinova@google.com> Commit-Queue: Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/main@{#1386539}
https://chrome-internal.googlesource.com/devtools/devtools-internal.git/+log/dcef03cf6f12..56577802b23f Also rolling transitive DEPS: https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f32abaa557c50c5a385008fe10c554f8abb8b67c..771bd74a56cff3e4eab6f214688ceafa0d3a29be If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/devtools-internal-chromium Please CC devtools-waterfall-sheriff-onduty@rotations.google.com,liviurau@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: devtools-waterfall-sheriff-onduty@rotations.google.com Change-Id: Ia9ab1c3c8dd9992274fa2a9f6905702bcecfdb55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6042643 Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1386540}
https://chrome-internal.googlesource.com/chrome/components/optimization_guide.git/+log/b65bdaacd4c9..808a0b380088 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/optimization-guide-chromium Please CC chrome-intelligence-core@google.com,sophiechang@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Change-Id: Iec9fea705818d638a6dffeb73d5f59bf129bb597 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6042853 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1386541}
R=rubber-stamper@appspot.gserviceaccount.com Bug: 380287135 Change-Id: Idd15e40f9c555f9095e7e97fe71f30499e12b912 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6042095 Auto-Submit: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1386542}
https://chromium.googlesource.com/v8/v8.git/+log/c657fe3a38b2..e60106438a80 2024-11-21 v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Version 13.3.123 2024-11-21 mfarazma@redhat.com PPC: merge Simd splat opcodes 2024-11-21 choongwoo.han@microsoft.com [shadow stack] Push a dummy shadow stack value in WasmTrapHandlerLandingPad 2024-11-21 mfarazma@redhat.com s390: [wasm][cfi] add Assembler functions to call/resolve WasmCodePointers 2024-11-21 evih@google.com [wasm][code-flushing] Remove flush_liftoff_code flag 2024-11-21 thibaudm@chromium.org [wasm] Remove unused far jump table slots 2024-11-21 ahaas@chromium.org [benchmark] Add a benchmark to compare fast API calls to regular ones 2024-11-21 irezvov@chromium.org [wasm] Preserve FP param and result registers on a stack grow and shrink event 2024-11-21 clemensb@chromium.org [wasm] Remove redundant methods from TypeCanonicalizer If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/v8-chromium-autoroll Please CC liviurau@google.com,machenbach@google.com,v8-waterfall-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:dawn-linux-x64-deps-rel Change-Id: If26312985c868e8f05b15923373c3d5c8e8998e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6042636 Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1386543}
Bug: 378838341 Change-Id: Ia8dd4a6725946e47dad965f89f4f84c241f969c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6039892 Commit-Queue: Fiorella Barrientos Villalta <fiorellab@google.com> Reviewed-by: Sophie Chang <sophiechang@chromium.org> Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/main@{#1386544}
Bug: 380327348 Change-Id: I514b1e31d192e0e59afc756bb94e2c005f4f6c48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6040385 Owners-Override: Eugene Zemtsov <ezemtsov@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Cr-Commit-Position: refs/heads/main@{#1386545}
After this change empty input nor longer hangs the fuzzer. Bug: 378866774 Change-Id: Ia947c62a77ad1bfcc969f04f8d8c21588dbe01d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6041255 Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Auto-Submit: Eugene Zemtsov <eugene@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/main@{#1386546}
https://android.googlesource.com/platform/external/perfetto.git/+log/834aa3bcb441..57e9e9ce02fc 2024-11-21 carlscab@google.com Merge "Add PerfTracker" into main If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com,primiano@chromium.org on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I5333553fb1f5131dee3cbd16df580799ef694245 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6042720 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1386547}
In the GoogleTest framework, underscores are not allowed.[1] Chromium has underscores in many test names, and those should be changed. This CL is generated after processing by clang-tidy[2]. [1] https://github.com/google/googletest/blob/main/docs/faq.md#why-should-test-suite-names-and-test-names-not-contain-underscore [2] https://issues.chromium.org/issues/377144451#comment4 Bug: 377144451 Change-Id: I7c6bcc3e39049f251b3f2881f7550199e794c53f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6038453 Reviewed-by: Zijie He <zijiehe@google.com> Reviewed-by: Wez <wez@chromium.org> Commit-Queue: Ho Cheung <hocheung@chromium.org> Cr-Commit-Position: refs/heads/main@{#1386548}
https://chromium.googlesource.com/libyuv/libyuv.git/+log/6ac7c8f25170..307b951229cc $ git log 6ac7c8f25..307b95122 --date=short --first-parent --format='%ad %ae %s' 2024-11-19 fbarchard Add CopyPlane_Unaligned, _Any and _Invert tests/benchmarksCpuId test 2024-11-16 fbarchard CpuId test FSMR - Fast Short Rep Movsb - Renumber cpuid bits to use low byte to ID the type of CPU and upper 24 bits for features 2024-11-14 fbarchard SplitRGB for SSE4 and AVX2 2024-05-16 george.steed [AArch64] Add SVE2 implementations of {P210,P410}ToAR30Row 2024-05-16 george.steed [AArch64] Add SVE2 implementation of I210ToARGBRow 2024-11-12 fbarchard Use grep extended regex for version 2024-05-16 george.steed [AArch64] Add SVE2 implementation of P410ToARGBRow 2024-05-16 george.steed [AArch64] Add SVE2 implementation of P210ToARGBRow 2024-10-04 george.steed [AArch64] Add SME implementation of ScaleUVRowDown2Box 2024-10-04 george.steed [AArch64] Add SME implementation of ScaleUVRowDown2Linear 2024-08-27 george.steed [AArch64] Add SME implementation of ScaleUVRowDown2 2024-11-12 george.steed CMakeLists.txt: Fix typo: OLD_CMAKE_{REQURED => REQUIRED}_FLAGS 2024-05-07 george.steed [AArch64] Add SVE2 implementations of HalfFloat{,1}Row 2024-09-17 george.steed [AArch64] Add comments to ScaleRowDown38_{2,3}_Box_NEON impls 2024-05-05 george.steed [AArch64] Add SVE2 implementation of DivideRow_16 2024-08-27 george.steed [AArch64] Add SME implementation of ScaleRowDown2Box 2024-08-27 george.steed Remove duplicate kernel assignment from scale_uv.cc 2024-05-07 george.steed [AArch64] Unroll HalfFloat{,1}Row_NEON 2024-08-27 george.steed [AArch64] Add SME implementation of ScaleRowDown2Linear 2024-08-27 george.steed [AArch64] Add SME implementation of ScaleRowDown2 2024-08-22 george.steed [AArch64] Add SME implementation of I444ToARGBRow 2024-06-12 george.steed [AArch64] Add SME implementation of I422ToARGBRow 2024-09-17 george.steed [AArch64] Optimize ScaleRowDown38_3_Box_NEON 2024-09-17 george.steed [AArch64] Optimize ScaleRowDown38_2_Box_NEON 2024-05-05 george.steed [AArch64] Add SVE2 implementation of I422ToARGB4444Row 2024-05-05 george.steed [AArch64] Add SVE2 implementation of I422ToARGB1555Row 2024-05-03 george.steed [AArch64] Add SVE2 implementation of I422ToRGB565Row 2024-05-15 george.steed [AArch64] Rework data loading in ScaleFilterCols_NEON 2024-09-18 george.steed [AArch64] Avoid partial vector stores in ScaleRowDown38_NEON 2024-05-03 george.steed [AArch64] Add SVE2 implementation of I422ToRGB24Row Created with: roll-dep src/third_party/libyuv R=fbarchard@chromium.org Change-Id: Ie840f469aa271c168ce187c9b0574e0986254816 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6039913 Reviewed-by: Frank Barchard <fbarchard@chromium.org> Commit-Queue: Wan-Teh Chang <wtc@google.com> Cr-Commit-Position: refs/heads/main@{#1386549}
Fixes a bug in the toolbar entrypoint that it doesn't close if the side panel if the live page is showing. Bug: 377531254 Change-Id: I5a31a309694da6e99804e7388c7504776cc7b88b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6037578 Reviewed-by: Juan Mojica <juanmojica@google.com> Commit-Queue: Duncan Mercer <mercerd@google.com> Auto-Submit: Duncan Mercer <mercerd@google.com> Reviewed-by: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/main@{#1386550}
This CL will make sure that the system tray bubble will update its bounds when the virtual keyboard is shown or hidden. Bug: b:368210555 Test: added UnifiedSystemTrayTest.VirtualKeyboardBubbleLayout Change-Id: I9c2d01ebadc919b06b14aad76ba981fb22060088 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6036616 Commit-Queue: Richard Chui <richui@chromium.org> Reviewed-by: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/main@{#1386551}
Update magicboost related search tags each time the settings app is opened, to resolve a missing search tags issue caused by a race condition. Bug: b:379281461 Test: CQs Test: verified on DUT Change-Id: Ia810d178e7de0ff641e5011ec813961d701d5527 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6037025 Reviewed-by: Nikki Moteva <moteva@google.com> Reviewed-by: Wes Okuhara <wesokuhara@google.com> Commit-Queue: Xinglong (Alan) Luan <alanlxl@chromium.org> Cr-Commit-Position: refs/heads/main@{#1386552}
https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/215dce6e6aec..689d3f1b77c7 2024-11-21 demenev2002@yandex.ru [libc] Fix wrong name in Compare.h (#117223) 2024-11-21 dthorn@google.com Reapply "[libc] Use best-fit binary trie to make malloc logarithmic (#117065)" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/llvm-libc-chromium Please CC akhuang@google.com,lexan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: akhuang@google.com Change-Id: I671c74147fd5e366ff8267722f437fe48265d1c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6042539 Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1386553}
Roll Chrome Win64 PGO profile from chrome-win64-main-1732201096-ce62e6eb0e1a7b867ec0ed377a4656043fe90f8a-7ae7fe4b3177d03e91ff2e92f917364f30e44b19.profdata to chrome-win64-main-1732211860-0ee96b2a86a2fe1d814a115c9a0058a358e685df-ab62e5a9221a3a39d6101afb0430d0d0e311fb91.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Iee9fdcc42f3d7dc54eedab14a06bc93710379c86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6042614 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1386554}
As android-15 CI bot is up and garderned removing the stable suites from the fyi builder. Bug: 339327094 Change-Id: I9ea2436fd32c8a7a2494da45c6e54fbab1910d66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6042724 Auto-Submit: Renuga Nanjappan <rnanjappan@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Reviewed-by: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/main@{#1386555}
Previously the try job was successfully ramped to 100%, but doing so introduced a bug where it was a no-op that didn't execute the compilation step. Change-Id: I40fd35a271e783fd949e0104e285e3020d2ffb7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6038665 Reviewed-by: Garrett Beaty <gbeaty@google.com> Reviewed-by: Erik Staab <estaab@chromium.org> Commit-Queue: Matt Stark <msta@google.com> Auto-Submit: Matt Stark <msta@google.com> Commit-Queue: Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/main@{#1386556}
Enable the android-14 pixel tablet builder on branches. Enable gardener and tree closing. Bug: 371224006 Change-Id: Ifb532719c5d997598ae29d8cacb160dd9f37b377 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6031941 Reviewed-by: Haiyang Pan <hypan@google.com> Commit-Queue: Renuga Nanjappan <rnanjappan@chromium.org> Cr-Commit-Position: refs/heads/main@{#1386557}
Cached selection menu is shown for repeated selections on same text as per current implementation. A delegate may provide user the ability to manage/modify the menu items in the selection menu which is not reflected currently if they repeat the same selection due to caching applied in SelectionPopupControllerImpl. Added canReuseCachedSelectionMenu API in SelectionActionMenuDelegate which lets SelectionPopupController check if caching is allowed by embedder or not. Bug: 378623798 Signed-off-by: anukul.chand <anukul.chand@samsung.com> Change-Id: I02b46dc5f4ab328fbe5a2f3dc8fb565714584a79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6021765 Commit-Queue: Ted Choc <tedchoc@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/main@{#1386558}
Roll Chrome Android ARM64 PGO profile from chrome-android64-main-1732225744-6a09a4bf7401952b420e8ed19a06380ef1e94149-0ed60de6722a92e26311a386a7f5045de87949fd.profdata to chrome-android64-main-1732230518-70f0b2320f89c1c4d5284e2b4f5f741d34d2e4cf-5bcec630861d33eabe6cd60c391c689cc77da76c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-android-arm64-chromium Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: pgo-profile-sheriffs@google.com Change-Id: Ifccb45267f828d9c86b5f5a787cbd03229bdf9c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6042545 Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1386559}
Summary: This change migrates the `DeclarativeNetRequestResourceTypeBrowserTest` from `SpawnedTestServer` to `EmbeddedTestServer`. The migration aims to standardize testing infrastructure, improve test reliability, and reduce dependencies on the older `SpawnedTestServer`. By utilizing `EmbeddedTestServer`, significant performance improvements are expected. Details: - Replaced `SpawnedTestServer` with `EmbeddedTestServer` for WebSocket resource type testing. Benefits: - Substantial speed improvements for test execution, reducing overall runtime significantly. - Aligns the test with modernized `EmbeddedTestServer`, simplifying maintenance and enhancing modularity. - Improves test reliability by reducing flakiness associated with `SpawnedTestServer`. - Facilitates consistency across tests by using a unified test server framework. Test Plan: - Verified that the updated `DeclarativeNetRequestResourceTypeBrowserTest` passes successfully with `EmbeddedTestServer`. - Ensured the WebSocket echo server functionality remains intact. Bug: 40812029 Change-Id: I9312dffb01334733b73ac6d1c5cd7b27d16d8390 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6040756 Commit-Queue: Ryosuke Miyake <rysk@google.com> Reviewed-by: Huanpo Lin <robertlin@chromium.org> Reviewed-by: Devlin Cronin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/main@{#1386560}
Bug: 376497141 Change-Id: I2281728856bc5a00549ea86a01b54e84db645aa4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6042812 Reviewed-by: Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/main@{#1386561}
The bot migration have completed. https://chromium-swarm.appspot.com/botlist?c=id&c=task&c=builder&c=os&c=status&d=asc&f=pool%3Aluci.chromium.ci&f=ssd%3A0&f=cores%3A32&f=os%3AWindows&k=builderless&s=id This CL drops `|32` dimension from `cores`, and sets `ssd:1`. Change-Id: I96b2f17d65ffe4a86f42a1f239d52b571dd5a584 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6038974 Reviewed-by: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Junji Watanabe <jwata@google.com> Commit-Queue: Junji Watanabe <jwata@google.com> Cr-Commit-Position: refs/heads/main@{#1386562}
Seems these files were able to stay in the codebase despite my removal CLs. These files were already removed from BUILD files and should just be dead code. Change-Id: I33ad02b75a7451c390d84f8ebbdca2c0eb2c74cd Bug: b:348678854 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6039496 Reviewed-by: Duncan Mercer <mercerd@google.com> Commit-Queue: Juan Mojica <juanmojica@google.com> Reviewed-by: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/main@{#1386563}
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/090b7be49149..2084c43cbb89 2024-11-21 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC chops-source-team@google.com,ddoman@google.com,jojwang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ddoman@google.com,jojwang@google.com Change-Id: I1db1e9b9336db0509109345aad17a3f283eec9af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6042540 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1386564}
Bug: 380333248 Change-Id: I2c0ce9c3fdd67e8977395f4580257e4cd4becf82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6040534 Owners-Override: Robert Lin <robertlin@google.com> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Huanpo Lin <robertlin@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/main@{#1386565}
Bug: 40927698 Change-Id: I4d6f754cf0caebd1a26f9c1b3a23c4c3a8fa3937 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6040361 Reviewed-by: Xiang Xiao <xiangxiao@google.com> Commit-Queue: Xiang Xiao <xiangxiao@google.com> Auto-Submit: Kristi Saney <kristislee@google.com> Cr-Commit-Position: refs/heads/main@{#1386566}
In `DesktopAndroidExtensionsBrowserClient`, ensure `GetContextRedirectedToOriginal()` returns the original browser context for Off-The-Record (OTR) contexts. This fixes the regression causing `CookiesFetcherRestoreUtilBrowserTest` failure. Bug: 380314905 Change-Id: I2f108d64f310b050fa6593881beacb6e06576cd4 Cq-Include-Trybots: luci.chromium.try:android-desktop-arm64-compile-rel,android-desktop-x64-compile-rel,android-desktop-14-x64-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6039478 Reviewed-by: Devlin Cronin <rdevlin.cronin@chromium.org> Commit-Queue: Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/main@{#1386567}
https://android.googlesource.com/platform/external/perfetto.git/+log/834aa3bcb441..57e9e9ce02fc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC chrometto-team@google.com,perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I7c2e89de5b597a5d587bb2bbb9a15ba9cc87e6c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6042778 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1386568}
*Note to gardeners*: If you see a few flakes, please prefer adding exclusion rules to `headless_shell.filter` to reverting. See [0] and [1] for background, and https://crrev.com/c/6020326 and https://crrev.com/c/6025361 for similar CLs. Starting from this CL, almost all virtual tests will run against headless shell via WebDriver instead of against content shell. Tests known to regress or flake under the new runner will continue running against content shell temporarily, but test owners should burn down these exceptions over time. To accommodate the new traffic, increase shard counts for the `(high_dpi_|not_site_per_process_|)headless_shell_wpt_tests` suites to their pre-migration `(high_dpi_|not_site_per_process_|)blink_wpt_tests` counterparts [2, 3, 4]. After this, we will revert the relevant parts of https://crrev.com/c/6022160 so that the autosharder's next run adjusts `*_wpt_tests` sharding. [0]: https://groups.google.com/a/chromium.org/g/blink-dev/c/JOu9l2hu1U8 [1]: https://chromium.googlesource.com/chromium/src/+/HEAD/docs/testing/run_web_platform_tests.md [2]: https://source.chromium.org/chromium/chromium/src/+/main:infra/config/generated/builders/try/mac-rel/targets/chromium.mac.json;l=1389;drc=9bef1809da3e164eefe4acaa10ddd289890b5a05;bpv=0;bpt=0 [3]: https://source.chromium.org/chromium/chromium/src/+/main:infra/config/generated/builders/try/win-rel/targets/chromium.win.json;l=1799;drc=2484981ee99a7b2937e518e208067617b2f930b3;bpv=0;bpt=0 [4]: https://source.chromium.org/chromium/chromium/src/+/main:infra/config/generated/builders/try/linux-rel/targets/chromium.linux.json;l=1425;drc=ffd283e388fd955b89f33de147ee07a21d8601a2;bpv=0;bpt=0 Bug: 40927590 Validate-Test-Flakiness: skip Change-Id: I1d1b15f6696b03ef33b2f98c0bcd4915a3826278 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6032153 Reviewed-by: Weizhong Xia <weizhong@google.com> Reviewed-by: Ben Pastene <bpastene@chromium.org> Commit-Queue: Jonathan Lee <jonathanjlee@google.com> Cr-Commit-Position: refs/heads/main@{#1386600}
Add a multiplicative backoff timer to SODA installation, so that any error attempts a reinstall. The backoff timer defaults to a max delay of 32 seconds. Ideally, DLC handles intermittent errors internally, but we do this to avoid cases where DLC may not yet be available. Bug: b:369008001,b:372340605 Change-Id: I002764ee60feb751f9b3d500b8b1b87b4ce67ca6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5889071 Reviewed-by: Andrew Moylan <amoylan@google.com> Commit-Queue: Rob Schonberger <robsc@chromium.org> Reviewed-by: Evan Liu <evliu@google.com> Cr-Commit-Position: refs/heads/main@{#1386601}
This test was found when enabling the chrome.browsingData API: https://chromium-review.googlesource.com/c/chromium/src/+/6023932 Enabling the test requires enabling a mock object on android, as well as the real underlying object and an extension utilities file. Hopefully these will provide useful for future refactors. Bug: 371426261 Test: unit_tests --gtest_filter=*ChromeBrowsingDataRemoverDelegateTest* Change-Id: I2e34a9939946918f462def85fbd801a2ceb113be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6037417 Reviewed-by: David Bertoni <dbertoni@chromium.org> Reviewed-by: Ayu Ishii <ayui@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/main@{#1386602}
… android" This reverts commit 9a78ab2. Reason for revert: This seems to cause tree closure due to changing the include logic of "storage/browser/quota/special_storage_policy.h" https://ci.chromium.org/ui/p/chromium/builders/ci/android-desktop-x64-compile-rel/7227/ Original change's description: > extensions: Enable browsing data remover unit test on desktop android > > This test was found when enabling the chrome.browsingData API: > https://chromium-review.googlesource.com/c/chromium/src/+/6023932 > > Enabling the test requires enabling a mock object on android, as well > as the real underlying object and an extension utilities file. > Hopefully these will provide useful for future refactors. > > Bug: 371426261 > Test: unit_tests --gtest_filter=*ChromeBrowsingDataRemoverDelegateTest* > Change-Id: I2e34a9939946918f462def85fbd801a2ceb113be > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6037417 > Reviewed-by: David Bertoni <dbertoni@chromium.org> > Reviewed-by: Ayu Ishii <ayui@chromium.org> > Commit-Queue: James Cook <jamescook@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1386602} Bug: 371426261 Change-Id: I976b5ad19daefdb03450c90833b15f00c3c694ff No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6041360 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Robert Lin <robertlin@google.com> Commit-Queue: Huanpo Lin <robertlin@chromium.org> Cr-Commit-Position: refs/heads/main@{#1386603}
Currently, if a given resolution is not supported by the hardware, the `error` event will be trigger but the error is an unknown error with a default error message `Video encoding failed`, other type of encoding error also doesn't passed correctly. Change the code to pass the actual error message will be helpful for the developer to know what happened. Bug: 40276507 Change-Id: I840c1bd994552ef59445a821cfaca1a96b3531fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6029396 Commit-Queue: Sida Zhu <zhusida@bytedance.com> Reviewed-by: Eugene Zemtsov <eugene@chromium.org> Cr-Commit-Position: refs/heads/main@{#1386604}
- The device.SetDeviceLostCallback and device.SetUncapturedErrorCallback entry points are going to be deprecated so remove their references now. - To avoid the UAF bug we saw in crbug.com/352610611 when I first tried to do this before in https://chromium-review.googlesource.com/c/chromium/src/+/5661562, make the device lost callback own the uncaptured error callback and free it when the lost callback runs. For some context, I believe that the previous UAF was caused when the following sequence of events happened: 1) Renderer creates device and runs a bunch of commands where at least one of the commands will result in the uncaptured error firing. 2) Renderer (client) flushes the stream of commands to the GPU process. 3) Renderer (client) drops all the WebGPU objects in JS, and the GC decides to clean up the WGPUDevice, but not necessarily all objects that hold a reference to the wgpu::Device, so the device lost callback is not yet triggered, however, the uncaptured error callback that was owned by the WGPUDevice is now freed. 4) The GPU process (server) flushes the errors and as a result tries to call the uncaptured error callback that no longer exists. The crux of the issue in that sequence is that Dawn only guarantees that the uncaptured error callback will not be triggered after the device lost callback has fired. By moving the deallocation of the uncaptured error callback into the device lost callback, we should no longer see the UAF. Bug: 42241415 Change-Id: Ib50182853ec2a456a489d73439dbf6ee42a2d36d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6040433 Commit-Queue: Loko Kung <lokokung@google.com> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Auto-Submit: Loko Kung <lokokung@google.com> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/main@{#1386605}
https://chromium.googlesource.com/angle/angle.git/+log/a58b35bcc692..10c2dc7a1b4b 2024-11-22 a.dean1@samsung.com CL: Remove logic restricting CL version of passthrough backend If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: geofflang@google.com Change-Id: Ic3110facb1806753926cafa999d5705dc25fbc3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6043093 Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1386606}
https://chromium.googlesource.com/external/github.com/gpuweb/cts.git/+log/91a2cfe45c9a..0c09a6613335 2024-11-22 github@greggman.com Compat: Don't test depth textures with non-comparison samplers (#4054) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webgpu-cts-chromium-autoroll Please CC bajones@google.com,webgpu-developers@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-android-arm-deps-rel;luci.chromium.try:dawn-android-arm64-deps-rel;luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-mac-arm64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel;luci.chromium.try:dawn-win11-arm64-deps-rel Bug: None Tbr: bajones@google.com Change-Id: I34f7db39d9e1da7d46ad686f70fcc95bf22ec203 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6042899 Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1386607}
https://chromium.googlesource.com/vulkan-deps.git/+log/316a62cbf14c..0e71ad9d032a Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/ad64122ab1f682b9bb1e415975853c1906567797..04ca7c3ba044cb89581b80f39859a4780d24e21e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-chromium-autoroll Please CC angle-team@google.com,bajones@google.com,geofflang@google.com,radial-bots+chrome-roll@google.com,radial-bots@google.com,webgpu-developers@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86;luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:win-asan;luci.chromium.try:linux_chromium_cfi_rel_ng Bug: None Tbr: bajones@google.com,geofflang@google.com,radial-bots+chrome-roll@google.com Change-Id: I28d86fbf020ff4b12c0262563c56251a03cf54f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6042646 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1386608}
Roll Chrome Android ARM64 PGO profile from chrome-android64-main-1732235152-fc8a92e5efc2ef79e7ffeb6dfa89fda94778bd00-91a09425eabf38f828ed07d4fbb5b95f18930d6b.profdata to chrome-android64-main-1732241321-ce16751b620615ed8e40d22b3a26f2f31b1b46c8-be75fe5a5be15e3531b12d0ac47b9eeb74f875c2.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-android-arm64-chromium Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: pgo-profile-sheriffs@google.com Change-Id: I80b4a183efc3c27a50a75c720002875c278f890d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6038280 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1386609}
One of the problems with CLIENT_OWNS_WIDGET is that code other than the client that owns the widget (such as DialogDelegate) can close the widget, which is an asynchronous operation. This means that clients need to handle the edge case of: Widget exists, but is closed. This adds complexity and edge cases. This CL continues to (intentionally) not handle the edge case of: NativeWidget is destroyed, but Widget still exists. In cases where the client owns the widget, the only way to close the widget should be for the client to reset the unique_ptr. This gives the client precise control over widget lifetimes, and provides an easy mechanism to (e.g. log exactly once when the widget is closed). Widget::MakeCloseSynchronous provides this mechanism. Using this effectively invalidates the need for Widget::Close(), Widget::CloseWithReason(), WidgetObserver destruction events, and methods on DialogWidget/WidgetDelegate. Bug: 377803489 Change-Id: Ia5c76a55024eeeaeadc96ae47414c697e566c281 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6033000 Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> Reviewed-by: Keren Zhu <kerenzhu@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/main@{#1386610}
Summary: This change migrates the `api_browsertest` suite for the `StorageAccessAPIBrowserTest` from the deprecated `SpawnedTestServer` to the modern `EmbeddedTestServer`. The update enhances the maintainability, reliability, and modularity of the test infrastructure. Details: - Replaced `SpawnedTestServer` with `EmbeddedTestServer` for WebSocket testing. - Removed the dependency on `SpawnedTestServer` for WebSocket-related functionality. Benefits: - Aligns the test suite with the actively maintained `EmbeddedTestServer`. - Improves reliability by reducing flakiness associated with `SpawnedTestServer`. - Simplifies maintenance and enables better integration with the broader testing framework. - Ensures compatibility with modern Chromium testing standards. Test Plan: - Verified that all `StorageAccessAPIBrowserTest` cases pass successfully with `EmbeddedTestServer`. - Ensured WebSocket functionality, including echoing request headers, operates as expected. - Validated that test results remain consistent with the previous implementation. Bug: 40812029 Change-Id: Ia2abfef72dbd10a60b0eac52cd8587b0c8ca0316 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6041357 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by: Adam Rice <ricea@chromium.org> Reviewed-by: Erik Chen <erikchen@chromium.org> Auto-Submit: Ryosuke Miyake <rysk@google.com> Reviewed-by: Huanpo Lin <robertlin@chromium.org> Cr-Commit-Position: refs/heads/main@{#1386611}
https://gn.googlesource.com/gn.git/+log/24e92acb8472..468c6128db7f 2024-11-22 tikuta@google.com fix include for escape.h 2024-11-22 tikuta@google.com fix exit code for gn gen failure If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/gn-chromium-autoroll Please CC dpranke@chromium.org,dpranke@google.com,thakis@chromium.org on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: dpranke@chromium.org,thakis@chromium.org Change-Id: I2a03fa1b9b0094469f320c701d2bf85b9b8f7cdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6042987 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1386612}
* This is an automated release commit. * Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true Change-Id: I4af77ba7b21594dba5cbc5c8556aab49ac5a17b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6038282 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1386613}
The config was changed unexpectedly in https://crrev.com/d87376155262aac8385bb9f7de1eb6d73aee0a64 Change-Id: I8864942def0c06bfd4f16ca3d7a311d37017cc74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6043013 Reviewed-by: Takuto Ikuta <tikuta@chromium.org> Reviewed-by: Fumitoshi Ukai <ukai@google.com> Commit-Queue: Junji Watanabe <jwata@google.com> Auto-Submit: Junji Watanabe <jwata@google.com> Cr-Commit-Position: refs/heads/main@{#1386614}
This CL add temporal scalability support and test coverage for AV1 bitstream builder, for vaapi/d3d12 api to use. TEST: build media_unittests, then execute it with --gtest_filter=AV1BuilderTest.* Bug: 40275246,b/378401081 Change-Id: I45cdabfb8ff4de21379887f14f31459393970d8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6021470 Reviewed-by: Hirokazu Honda <hiroh@chromium.org> Reviewed-by: Nathan Hebert <nhebert@chromium.org> Commit-Queue: Yingying Ma <yingying.ma@intel.com> Reviewed-by: Zhaoliang Ma <zhaoliang.ma@intel.com> Cr-Commit-Position: refs/heads/main@{#1386615}
The Enable prefix is confusing and not necessary. These base feature flags have 2 uses - testing, this CL will have to wait for https://crrev.com/i/7836570 to be rolled into the main repo before submitting - kill-switch, not currently used, if we do kill, we will need to consider that older milestones use the old names. Change-Id: I672b0fce708bdecf0b881d938d5ca654f148d289 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6029594 Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by: Jiacheng Guo <gjc@google.com> Reviewed-by: Monica Basta <msalama@chromium.org> Reviewed-by: Devlin Cronin <rdevlin.cronin@chromium.org> Reviewed-by: Tsuyoshi Horo <horo@chromium.org> Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> Reviewed-by: Owen Min <zmin@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/main@{#1386616}
Roll Chrome Win64 PGO profile from chrome-win64-main-1732211860-0ee96b2a86a2fe1d814a115c9a0058a358e685df-ab62e5a9221a3a39d6101afb0430d0d0e311fb91.profdata to chrome-win64-main-1732222768-b489f19624b5b3efa34b6700bdd733793f5e72f6-4b5cddca4420b282951040c695ea34bdc9408edf.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ib7b31a0e87f3ac8998c346f9199639ad9f2d3585 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6042546 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1386617}
Some events might directly change page visibility (for example: <a target=_blank> links). When this happens, we have started measuring event timing for an event, haven't yet finished measurement for it, and yet we try to 'flush' it immediately on the visibilitychange. Previously we would just not have reported this event at all, because it would not yet have been Registered at all. This fix returns to that behaviour by skipping the visibility change flushing behaviour when events are still in the middle of dispatch. Potential followups might be to investigate if we are observing visibility change correctly. Ideally we would flush event timings as part of the page lifecycle events (so you can still calculate and beacon INP data for links that unload the document), but be resilient to use cases like this one. Bug: 379866953, 380204940 Change-Id: I47f74857800292048edfeeccc8d7474c9d512675 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6042358 Auto-Submit: Michal Mocny <mmocny@chromium.org> Reviewed-by: Ian Clelland <iclelland@chromium.org> Commit-Queue: Michal Mocny <mmocny@chromium.org> Cr-Commit-Position: refs/heads/main@{#1386618}
Compiler typesafety for ids can help prevent serious bugs from occurring. Adding a std::hash function makes using StrongAlias and IdType seamless with many containers. Bug: 379869738 Change-Id: I6a4ac058f4b5dfc9cf4a6c211439a7ce5147534d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6036835 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Commit-Queue: Emily Andrews <emiled@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1386619}
Bug: 361751872 Change-Id: Icd45dcf7e500c99eaae5ccc059690580be258973 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6034990 Reviewed-by: Andrew Williams <awillia@chromium.org> Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: Andrew Williams <awillia@chromium.org> Auto-Submit: Janice Liu <janiceliu@chromium.org> Cr-Commit-Position: refs/heads/main@{#1386620}
Roll Chrome Win32 PGO profile from chrome-win32-main-1732211860-2465260fe51c615a47d0ecf2d33a084ea741e1c2-ab62e5a9221a3a39d6101afb0430d0d0e311fb91.profdata to chrome-win32-main-1732222768-2d6090e193dcf1652975726d9a3ea7b918c689b2-4b5cddca4420b282951040c695ea34bdc9408edf.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Icc578fe49c1c2ce369c8731f569847ea76bcc6d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6042977 Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1386621}
Roll Chrome Android ARM64 PGO profile from chrome-android64-main-1732241321-ce16751b620615ed8e40d22b3a26f2f31b1b46c8-be75fe5a5be15e3531b12d0ac47b9eeb74f875c2.profdata to chrome-android64-main-1732246663-5b6d24f188d64171fdb6a5905de77aa9cd0c5742-56c4f0c6c9e5509cee941a3f78452a7738b99359.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-android-arm64-chromium Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: pgo-profile-sheriffs@google.com Change-Id: I5f6c082c4f78936106fc966844a6f35aaefd9284 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6038285 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1386622}
This is a reland of commit 5fa0d92 A crash was observed while accessing the DirectWritingServiceCallback. To address this issue, additional check is added to verify if the service callback constructor exists in isEnabled and if not, disables DW service. Original change's description: > Adds check for service callback before enabling DW. > > Checks whether the service callback constructor exists in isEnabled > and if not, disables DW service. This prevents crashing described in > crbug/1375266. > > Bug: 1375266 > Change-Id: Ie2134ccbdd627b38b1b46e8ad4053227f2b765fd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3960230 > Reviewed-by: Weilun Shi <sweilun@chromium.org> > Reviewed-by: Mahesh Machavolu <mahesh.ma@samsung.com> > Commit-Queue: Alex Mitra <alexmitra@chromium.org> > Reviewed-by: Peter Conn <peconn@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1060407} (cherry picked from commit 5fa0d92) Bug: 379724628 Change-Id: I6196cc70acd2d25ffed81e4be1e872106cb57cca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6038593 Reviewed-by: Darren Shen <shend@chromium.org> Reviewed-by: Alex Mitra <alexmitra@chromium.org> Commit-Queue: Mahesh Machavolu <mahesh.ma@samsung.com> Cr-Commit-Position: refs/heads/main@{#1386623}
https://chrome-internal.googlesource.com/clank/internal/apps.git/+log/520070b69724..5dd2aa33df05 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/clank-apps-chromium-autoroll Please CC chrome-brapp-engprod@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: No-Try: true Change-Id: I795a4c62344a43bf9878f1eb7f8279ca97da7abe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6043002 Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1386624}
Currently Translator API is not supported on workers. So this CL disables the API on workers. Bug: 375496221 Change-Id: If39f621d63ac73014dbf9f9c16ed6a1f77800266 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6038466 Reviewed-by: Yuzu Saijo <yuzus@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/main@{#1386625}
We assert that we don't try to create new memory objects of zero bytes, but we don't validate that a node requests > 0 bytes. Fixed: 379418966 Change-Id: Ice5c899481eee70de33ad5c8254a069945b0e58f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6042644 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/main@{#1386626}
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )