Merged
Conversation
This change is a NoOp. NO_IFTTT=Whitespace changes only. Bug: None. Change-Id: I77ffc633032ed2802f72443fd1e0515f9a8533ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6530801 Reviewed-by: Jan Keitel <jkeitel@google.com> Commit-Queue: Friedrich Hauser <friedrichh@chromium.org> Cr-Commit-Position: refs/heads/main@{#1458066}
https://chromium.googlesource.com/vulkan-deps.git/+log/69d81d41a450..72604f04b957 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/ecc85585e1000b4ac5974db083d8147d79678e78..6ae58a2b17b2bcebdc5377995007391b85ffa10f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-chromium-autoroll Please CC alanbaker@google.com,angle-team@google.com,radial-bots+chrome-roll@google.com,radial-bots@google.com,syoussefi@google.com,webgpu-developers@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86;luci.chromium.try:dawn-linux-x64-deps-rel Bug: None Tbr: alanbaker@google.com,radial-bots+chrome-roll@google.com,syoussefi@google.com Change-Id: I07c607121c57f86f04d238b5b63146133b8e87e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6531003 Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1458067}
- Initial value is `none` - Once a user starts scrolling the value changes based on the direction of scrolling and stays the same (even if they stop scrolling) until they start scrolling in different direction. - Horizontal/vertical scroll direction state are saved independently, e.g. if a user was scrolling to bottom and then starts to scroll left, scroll-state(scroll-direction: bottom) would still match. This Cl also includes few small fixes in core/css/media_query_evaluator.cc and core/css/media_values.h. Bug: 414556050 Change-Id: I90978330bfe3fefb280b20f7dba446e6e0983473 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6516195 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Munira Tursunova <moonira@google.com> Cr-Commit-Position: refs/heads/main@{#1458068}
https://chrome-internal.googlesource.com/clank/internal/apps.git/+log/183abddd96aa..62cdd1edaaf0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/clank-apps-chromium-autoroll Please CC chrome-brapp-engprod@google.com,sideyilmaz@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: sideyilmaz@google.com No-Try: true Change-Id: I7bffdeabfdbd6f10e39c587b9f4f5e7e080ea8a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6531021 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1458069}
…s actions" This reverts commit ff6e76a. Reason for reland: Fixed link error on fuzzer bot * Also made a couple other fuzzer-related GN simplifications. Original change's description: > Revert "Reland "Make proto_library() actions depend directly on their dep's actions"" > > This reverts commit c3c72ad. > > Reason for revert: suspect compile failure on Libfuzzer Upload Chrome OS Asan > > First build failure: > https://ci.chromium.org/ui/p/chromium/builders/ci/Libfuzzer%20Upload%20Chrome%20OS%20ASan/122004/overview > > Failure summary: > --- > [75972/75984] LINK ./policy_fuzzer > python3 ../../build/toolchain/gcc_link_wrapper.py --output=./policy_fuzzer -- ../../third_party/llvm-build/Release+Asserts/bin/clang++ -Werror...(too long) > ld.lld: error: duplicate symbol: enterprise_management::DevicePolicyRefreshRateProto::DevicePolicyRefreshRateProto(google::protobuf::Arena*) > >>> defined at chrome_device_policy.pb.cc:5287 (gen/components/policy/proto/chrome_device_policy.pb.cc:5287) > >>> obj/components/policy/proto/proto_internal/chrome_device_policy.pb.o:(enterprise_management::DevicePolicyRefreshRateProto::DevicePolicyRefreshRateProto(google::protobuf::Arena*)) > >>> defined at chrome_device_policy.pb.cc:7534 (gen/components/policy/proto/fuzzer/chrome_device_policy.pb.cc:7534) > >>> chrome_device_policy_full_runtime_proto__proto/chrome_device_policy.pb.o:(.text+0x0) in archive obj/components/policy/proto/fuzzer/libchrome_device_policy_full_runtime_proto__proto.a > --- > > Original change's description: > > Reland "Make proto_library() actions depend directly on their dep's actions" > > > > This reverts commit 3c31897. > > > > Reason for reland: Update dep labels > > > > Original change's description: > > > Revert "Make proto_library() actions depend directly on their dep's actions" > > > > > > This reverts commit 01bb32f. > > > > > > Reason for revert: broke https://ci.chromium.org/ui/p/chromium/builders/ci/Libfuzzer%20Upload%20Chrome%20OS%20ASan : > > > > > > ERROR Unresolved dependencies. > > > //chrome/browser/resources/chromeos/contact_center_insights:reporting_protos(//build/toolchain/linux:clang_x64) > > > needs //components/reporting/proto:proto_library_health_proto_gen(//build/toolchain/linux:clang_x64) > > > > > > and the latter is changed by this CL. > > > > > > Original change's description: > > > > Make proto_library() actions depend directly on their dep's actions > > > > > > > > Instead of on their source_set() targets, which blocks the actions on > > > > compile steps that it doesn't need. > > > > > > > > This necessitates removing visibility from the generation action, and > > > > thus removing the need for "generator_visibility", which IMO provided > > > > negative value. > > > > > > > > Change-Id: I75abd295ee5a2943fcdd9c4a15d569c43056b872 > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6505727 > > > > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > > > > Owners-Override: Andrew Grieve <agrieve@chromium.org> > > > > Reviewed-by: Takuto Ikuta <tikuta@chromium.org> > > > > Cr-Commit-Position: refs/heads/main@{#1456968} > > > > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Change-Id: Idd8cd73bf8d9485414d1adbade6bf9082010fb1c > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6519496 > > > Owners-Override: Avi Drissman <avi@chromium.org> > > > Auto-Submit: Avi Drissman <avi@chromium.org> > > > Commit-Queue: Avi Drissman <avi@chromium.org> > > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > > Cr-Commit-Position: refs/heads/main@{#1457005} > > > > Change-Id: I4f109ce03d7941df914b2dc01e99729b77950092 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6518391 > > Auto-Submit: Andrew Grieve <agrieve@chromium.org> > > Owners-Override: Andrew Grieve <agrieve@chromium.org> > > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > > Reviewed-by: Sam Maier <smaier@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#1457159} > > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Change-Id: I21b0b25281904a4db0ce35b5763a49c74aa37917 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6521886 > Auto-Submit: Takashi Sakamoto <tasak@google.com> > Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Owners-Override: Takashi Sakamoto <tasak@google.com> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Cr-Commit-Position: refs/heads/main@{#1457346} Change-Id: I48cff63e3dd7e8405af2ea9cdff175e27c69b1ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6528249 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by: Takuto Ikuta <tikuta@chromium.org> Owners-Override: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/main@{#1458070}
Currently only 3 permission elements are allowed per page. If this quota is reached, show a console nessage to the devs. Bug: 346956799 Change-Id: If55a8dd09ea65667197b838e7a0992d7f007692b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6524746 Commit-Queue: Ravjit Uppal <ravjit@chromium.org> Reviewed-by: Thomas Nguyen <tungnh@chromium.org> Cr-Commit-Position: refs/heads/main@{#1458071}
AwContents#onAttachedToWindow is called whenever the WebView is attached to the window, AwViewMethodsImpl is called whenever a View that contains the AwContents is attached to the window. This is different when the user has entered HTML5 full screen, when the AwContents is displayed through a FullScreenView. This change does change the semantics, although I believe it was unintentional that metrics were not collected for the FullScreenView. Bug: 380261043 Change-Id: I79b49a6046aa1806c40e33126aaa202594232abf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6508769 Reviewed-by: Kartar Singh <kartarsingh@google.com> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/main@{#1458072}
This CL move the TouchToFillResourceProvider from c/b/ttf/password_manager to the c/b/ttf/common directory to make the class more general purpose. It will we used from the payments TTF bottom sheet. The old version is kept for compatibility reasons and will be removed once the counterpart if removed from the internal repo. Bug: 415006335 Change-Id: I3989421bf5540cb1f67df0e82601f3b17af155f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6530603 Reviewed-by: Friedrich Hauser <friedrichh@chromium.org> Commit-Queue: Timofey Chudakov <tchudakov@google.com> Cr-Commit-Position: refs/heads/main@{#1458073}
https://chromium.googlesource.com/v8/v8.git/+log/66ae14d8c1ca..8906cfcbd48c 2025-05-09 v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Version 13.8.113 2025-05-09 mliedtke@chromium.org [wasm][shared] Add struct.atomic.get instruction for i32 and i64 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/v8-chromium-autoroll Please CC liviurau@google.com,machenbach@google.com,v8-waterfall-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:dawn-linux-x64-deps-rel Change-Id: I6b464303f9b26dbf69755393d068b2f904aeee18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6531140 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1458074}
Bug: 361560365 Change-Id: I91aa8f1639a90c049b39df12338e679624c1bfc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6531101 Commit-Queue: Karol Sygiet <sygiet@google.com> Reviewed-by: Jan Keitel <jkeitel@google.com> Cr-Commit-Position: refs/heads/main@{#1458075}
This reverts commit f2812e7. There is still a bug in this code, but efforts to find it have failed so far. Fixed: 389011795, 353737588 Change-Id: I6a0217a73e7abf86390f947f1b1be5f4012a1b13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6529968 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Auto-Submit: Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/main@{#1458076}
These histograms will measure the time spent on JNI calls through AwContentsIoThreadClient during URL load, to determine if there is room for improvement by refactoring how the variables are accessed. Bug: 416198999 Change-Id: I1068427c0d2295920dee8c73170009359f1fc2d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6520074 Reviewed-by: Rupert Wiser <bewise@chromium.org> Commit-Queue: Peter Pakkenberg <pbirk@chromium.org> Reviewed-by: Ashley Newson <ashleynewson@chromium.org> Cr-Commit-Position: refs/heads/main@{#1458077}
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1746784599-a43c3308e0f8fe89ce3ca0119eab01349db52f31-3ca3e0c36e96013871cc2ac817803e7269d32a95.profdata to chrome-mac-arm-main-1746791612-341b3deea92c468456fe169b01944b50f99f239d-4852d4ffeefa31265675175f00edcf84c5e30ecd.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-arm-chromium Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Merge-Approval-Bypass: Chrome autoroller Change-Id: I08838e8676b19a3151dd34eb993192b9544470ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6531263 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1458078}
Bug: 369797848 Change-Id: Ie4393af38684f40ed9df2bd537d066f53b3af7d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6523803 Reviewed-by: Dominik Bylica <bylica@google.com> Commit-Queue: Serhii Selyvon <sselyvon@google.com> Reviewed-by: Vlad Korotkevich <vkorotkevich@google.com> Cr-Commit-Position: refs/heads/main@{#1458079}
Change-Id: If5f77ea91b08c1144fecb23e5e20a2ce2d4a250e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6530824 Commit-Queue: Daniel Soromou <koretadaniel@chromium.org> Reviewed-by: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/main@{#1458080}
https://dawn.googlesource.com/dawn.git/+log/52a8b5a67e5c..8d9a27a2cf44 2025-05-09 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 86ce0f0e4054 to b729fb74e68b (5 revisions) 2025-05-09 jimblackler@google.com Kotlin: enable project to be built with Oracle or Android dialect jni.h If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC alanbaker@google.com,cwallez@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-android-arm-deps-rel;luci.chromium.try:dawn-android-arm64-deps-rel;luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-mac-arm64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel;luci.chromium.try:dawn-win11-arm64-deps-rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:gpu-fyi-cq-android-arm64 Bug: chromium:416428727 Tbr: alanbaker@google.com Test: Test: AsyncHelperTest Change-Id: I54f4f829b4cc888c42ad3894c368d96e12072a7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6531141 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1458081}
...for camera/mic on Windows. This is because the implementation of `Request` on Windows does not actually support camera/mic yet. Bug: 414523295 Change-Id: Ia6beb357e910ac1e55cb3655a2e174d90b2b8ff2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6530601 Reviewed-by: Elias Klim <elklm@chromium.org> Commit-Queue: Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/main@{#1458082}
Roll Chrome Android ARM64 PGO profile from chrome-android64-main-1746778608-03cafa167ccfd98d7f7fa596e3c804a3697ee966-f8e3fd713bce1388b96bac43cda4286e03004bf7.profdata to chrome-android64-main-1746787989-1b0705ba3b12e0b5dcdc35c163c48f9c1ba23b91-1fbabde01df7f39e54484a9c3150f175854aafb2.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-android-arm64-chromium Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: pgo-profile-sheriffs@google.com Merge-Approval-Bypass: Chrome autoroller Change-Id: I329a3d42f172ff930d3e5d59926298180ffc472d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6531262 Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1458083}
build/config/clang/BUILD.gn contains some logic that sets the path to Clang's runtime libraries. This makes use of a variable _use_cros_sysroot_libs, which is automatically computed as `is_chromeos_device && current_toolchain == default_toolchain`. This is based on the assumption that the toolchain used to build Chrome for ChromeOS is the toolchain that lives inside the ChromeOS chroot. We are now transitioning to building Chrome for ChromeOS with the toolchain that is bundled with Chrome. This will initially be tested on a few boards. When using the bundled toolchain, we should use the runtime libraries that come with it toolchain, rather than the ones from the ChromeOS chroot. To facilitate this, this change makes use_cros_sysroot_libs a GN argument, so that builds that use the bundled toolchain can set it to false. Eventually, we expect to be able to remove the variable and the logic that depends on it (once the bundled toolchain is used in all cases). Bug: 406492152 Test: Build with bundled toolchain and ChromeOS toolchain; both work Change-Id: If89e098c9094be06ef50bc37884a6fd2f1c1ba22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6508512 Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Bob Haarman <inglorion@chromium.org> Cr-Commit-Position: refs/heads/main@{#1458084}
https://webrtc.googlesource.com/src.git/+log/8ae8263ecc04..e4e347dc78ee 2025-05-09 solenberg@webrtc.org Revert "document footgun behavior of codec munging and setCodecPreferences" 2025-05-09 tov@chromium.org Add metrics for restricted candidates 2025-05-09 tov@chromium.org Add metrics for SDP munging outcome 2025-05-09 phancke@meta.com Remove platform-specific variable shadowing 2025-05-09 jwata@google.com infra: Switch Reclient to Siso's builtin RBE client 2025-05-09 phancke@meta.com document footgun behavior of codec munging and setCodecPreferences 2025-05-09 webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com Update WebRTC code version (2025-05-09T04:02:12). 2025-05-09 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 2cf9839..efebdb6 (1457781:1457935) 2025-05-08 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision a543dd4..2cf9839 (1457639:1457781) 2025-05-08 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 079e22a..a543dd4 (1457513:1457639) 2025-05-08 hta@webrtc.org Take out some superfluous webrtc:: prefixes 2025-05-08 ssilkin@webrtc.org Fix typos in adaptation doc 2025-05-08 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 34c4b0e..079e22a (1457124:1457513) 2025-05-08 hta@webrtc.org Use only PayloadTypeSuggester for PT assigment 2025-05-08 phancke@meta.com IWYU modules/audio_coding 2025-05-08 phancke@meta.com IWYU video/ 2025-05-08 solenberg@webrtc.org Revert "IWYU: fix generated protobuf include" 2025-05-08 jwata@google.com infra: fix typo for siso properties 2025-05-08 jwata@google.com infra: Switch WebRTC standalone bots from Ninja/Reclient to Siso/Reclient 2025-05-08 webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com Update WebRTC code version (2025-05-08T04:08:56). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com,webrtc-infra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in WebRTC: https://bugs.chromium.org/p/webrtc/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: chromium:40567530,chromium:412968361 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I192c8124e3b1507127766b4de8e642d943ae3dc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6531266 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1458085}
Roll Chrome Win32 PGO profile from chrome-win32-main-1746759389-a80b8166ea153c1c6d706e5092ee4d31d49e4041-5fc67995854e822b9f72ce7db6df7a9d9671e239.profdata to chrome-win32-main-1746781162-fbcd078ad2b2bfcff52f8988a317e59faaf22fbe-e0c80fb82378662bfbda6b8d2ad8ab52a41c0415.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Merge-Approval-Bypass: Chrome autoroller Change-Id: I26cf2684230c277be7e9fd7f09dae5429683a6a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6531040 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1458086}
…equest" This is a reland of commit f50b4c7 The difference can be seen between PS1 and PS2. Original CL forgot to update the model as it was supposed to. Original change's description: > WebAuthn: Skip to kGpmTouchId if supported by the immediate request > > This CL pre-calculates the UV method before displaying the UI. If the > calculated value allows inline touchID (a.k.a. kUVKeyWithChromeUI), > selects the priority mechanism. > > The next CL will be the browser tests for the case. So far tested > manually both for a bootstrapped and a non-bootstrapped account. > > Bug: 393055190 > Change-Id: I3f0473e77a6db8a249d34e3c6785efd35585ffa7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6516060 > Commit-Queue: Adem Derinel <derinel@google.com> > Reviewed-by: Ken Buchanan <kenrb@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1457990} Bug: 393055190 Change-Id: I2c8ff79d81256ac9d9f93cb282c7cb83992d4a7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6530406 Reviewed-by: Ken Buchanan <kenrb@chromium.org> Commit-Queue: Adem Derinel <derinel@google.com> Cr-Commit-Position: refs/heads/main@{#1458087}
This is usually not what the developer intended because it easy to miss a `&`, especially since `auto` by itself deduces to a value type and not a reference. /usr/local/google/home/tsepez/repo/chromium/src/services This CL was uploaded by git cl split. R=dcheng@chromium.org, morlovich@chromium.org Bug: 415953694 Change-Id: I9f6f24eadd3ebb56f85c477c7e1898a8c7110280 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6527490 Auto-Submit: Tom Sepez <tsepez@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/main@{#1458088}
fix for https://logs.chromium.org/logs/chrome/buildbucket/cr-buildbucket/8715424594639945777/+/u/Generate_Orderfile_for_arm64/stdout Traceback (most recent call last): File "/b/swarming/w/ir/cache/builder/src/tools/cygprofile/orderfile_generator_backend.py", line 1259, in CreateOrderfile return generator.Generate() ^^^^^^^^^^^^^^^^^^^^ File "/b/swarming/w/ir/cache/builder/src/tools/cygprofile/orderfile_generator_backend.py", line 1067, in Generate self._compiler.CompileChromeApk(instrumented=True) File "/b/swarming/w/ir/cache/builder/src/tools/cygprofile/orderfile_generator_backend.py", line 354, in CompileChromeApk self._Build(instrumented, self._chrome_target) File "/b/swarming/w/ir/cache/builder/src/tools/cygprofile/orderfile_generator_backend.py", line 309, in _Build process = self._step_recorder.RunCommand(self._ninja_command + ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/b/swarming/w/ir/cache/builder/src/tools/cygprofile/orderfile_generator_backend.py", line 188, in RunCommand process = subprocess.run( ^^^^^^^^^^^^^^^ File "/home/chrome-bot/.cache/vpython-root.1000/store/cpython+l5fnajrvijf7cvdkjqmbicg3i8/contents/lib/python3.11/subprocess.py", line 548, in run with Popen(*popenargs, **kwargs) as process: ^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/chrome-bot/.cache/vpython-root.1000/store/cpython+l5fnajrvijf7cvdkjqmbicg3i8/contents/lib/python3.11/subprocess.py", line 1026, in __init__ self._execute_child(args, executable, preexec_fn, close_fds, File "/home/chrome-bot/.cache/vpython-root.1000/store/cpython+l5fnajrvijf7cvdkjqmbicg3i8/contents/lib/python3.11/subprocess.py", line 1955, in _execute_child raise child_exception_type(errno_num, err_msg, err_filename) FileNotFoundError: [Errno 2] No such file or directory: '-remote_jobs' Bug: 379584977 Change-Id: Idcc36e35f2e6e116f9e4520da16e83da50ba17c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6528511 Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Fumitoshi Ukai <ukai@google.com> Reviewed-by: Junji Watanabe <jwata@google.com> Reviewed-by: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/main@{#1458089}
Roll Chrome Win ARM64 PGO profile from chrome-win-arm64-main-1746770214-3a984bff321e6159d531a9d2ca7aa7e2bce4b666-138306eae26b21ffa7139d2f39324827708eee3e.profdata to chrome-win-arm64-main-1746791612-bb69157dd5df12f835e6bc703c2b1fd59abc53eb-4852d4ffeefa31265675175f00edcf84c5e30ecd.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win-arm64-chromium Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: pgo-profile-sheriffs@google.com Merge-Approval-Bypass: Chrome autoroller Change-Id: If4f0df0dcaa8b7e33e17b600bc200472b306fbea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6531387 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1458090}
Bug: 366475997 Change-Id: I135f2d103b526714974d49203284ffe8cb975051 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6523363 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/main@{#1458091}
https://chromium.googlesource.com/v8/v8.git/+log/8906cfcbd48c..434b323b7b4c 2025-05-09 v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Version 13.8.116 2025-05-09 olivf@chromium.org [osr] Fix dcheck in when updating maybe_has_optimized_osr_code 2025-05-09 clemensb@chromium.org [api] Refactor Utils::ToLocal implementation 2025-05-09 leszeks@chromium.org Revert "[maglev] Inline Math.clz32" 2025-05-09 clemensb@chromium.org [api] Use 'i::' consistently instead of 'v8::internal::' 2025-05-09 wnwen@chromium.org pgo: Add more debugging instructions If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/v8-chromium-autoroll Please CC liviurau@google.com,machenbach@google.com,v8-waterfall-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:dawn-linux-x64-deps-rel Change-Id: I494c6c026868d2ca2cab032bb42602cede4d4ffc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6531182 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1458092}
Bug: 414826060,416558040 Change-Id: I944bc54d83acaa721282375d041c212ab61f4418 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6527026 Reviewed-by: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/main@{#1458093}
https://skia.googlesource.com/skia.git/+log/84e461a91558..37a86c69aa2b 2025-05-09 fmalita@google.com [path] Add fill type utils If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com,skiabot@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:gpu-fyi-cq-android-arm64;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:mac14.arm64-blink-rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: robertphillips@google.com Change-Id: Ifee7ea656667aad76b547e2954efaa87dc2726a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6531041 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1458094}
Don't force animation when HubContainerView RootView height has not been updated. When creating a new window with no regular tabs, the parent view for the HubContainerView is not initialized. In this unique case, we queue an animation, which is only run upon initialization of said parent. Bug: 414748354 Change-Id: I257f829211c922010b7695f0e715c417153203f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6526508 Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org> Commit-Queue: Fiaz Muhammad <mfiaz@google.com> Cr-Commit-Position: refs/heads/main@{#1458095}
This reverts commit f481bd6. Reason for revert: The Clang roll was reverted, so this is not needed anymore (see bug). Bug: 415842701 Original change's description: > Avoid icf=all on android due to crashing blink. > > icf=all causes crashing blink, use icf=safe instead. > > Note, the issue only impacts the thin-lto, and it's not used in > regular builders. > > This is a temporary fix similar to https://crrev.com/c/6518906 > > Binary-Size: temporary fix to fix blink crash > Bug: 415842701 > Change-Id: I223e7ebadfcae8d65d666ecf444bd73242713573 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6525830 > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Commit-Queue: Haiyang Pan <hypan@google.com> > Cr-Commit-Position: refs/heads/main@{#1457891} Bug: 415842701 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: I0fe09f21c15b7b0a9f6bbfe356c18b52d18977af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6532304 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/main@{#1458179}
Roll Chrome Android ARM64 PGO profile from chrome-android64-main-1746799127-51c54321ccda57f56f27d0c03911efb802b0c0db-24d6d1b1bfb7036877d0cf76c36f0b9c6f7c7c54.profdata to chrome-android64-main-1746803104-37944fb84c735c147673767db917bdcd86392021-bd07c116d751ed6557dd1e55f6aa8b0bd4e2fa5a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-android-arm64-chromium Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: pgo-profile-sheriffs@google.com Merge-Approval-Bypass: Chrome autoroller Change-Id: I359089e53bb96d81bb07a2636deeac7f82f12d69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6531816 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1458180}
This CL updates installOnDevice() to consume a user gesture. This is one of the anti-fingerprinting countermeasures described in go/on-device-web-speech-fingerprinting-mitigations. Bug: 40286514 Change-Id: I9acedbfda14917f8a7c15210bc05f37e635df2d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6521098 Commit-Queue: Evan Liu <evliu@google.com> Reviewed-by: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/main@{#1458181}
The read aloud bottom sheet when expanded is at the same priority as the TGP BS. Being at the same priority, the TGP BS is prevented from showing. This CL increases the priority of the BS. The rationale is that the TGP BS only shows for short times and blocks the usage of the rest of chrome while it is showing, which seems to make it a high priority UI element. Bug: 414723474 Change-Id: Ia70ef687df1fcfcd017f768fbc6282576ce88b0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6530764 Commit-Queue: Fiaz Muhammad <mfiaz@google.com> Reviewed-by: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/main@{#1458182}
Left a TODO for handling <image> values, which is behind a flag that is not enabled for testing and most likely will never ship. Bug: 416634198 Change-Id: I40755a051b00d7d8e99fe86a83dbf3b519025168 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6530425 Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/main@{#1458183}
The existing accessibility tests for canvas fallback content are modified to add layoutsubtree=true content, and one test is added for more complex fallback content including a list. The latter, and an existing table-as-child-of-canvas test now have layout information in their a11y tree. AX-Relnotes: When the CanvasElementDrawImage flag is enabled and a canvas element has the "layout-subtree=true" attribute, then children of the canvas are laid out, and hence their accessibility information includes information only available after layout, such as list markers. This flag and functionality is only available for developer trials at this time. Bug: 415324224 Change-Id: I6eb53217edc1f09ec2b0f6d87abd4d5f374e0682 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6514958 Reviewed-by: Mark Schillaci <mschillaci@google.com> Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by: Zijie He <zijiehe@google.com> Cr-Commit-Position: refs/heads/main@{#1458184}
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1746799127-efb74bc308adc589a7ed1cae4c5e88f5a27017ad-24d6d1b1bfb7036877d0cf76c36f0b9c6f7c7c54.profdata to chrome-mac-arm-main-1746806395-c902c3f70d0261dbd661234389ff93302a6d22ce-708b418891b191dfc63758b7cc95308d56e1a80a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-arm-chromium Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Merge-Approval-Bypass: Chrome autoroller Change-Id: I8c4b105af3eaca7d9c1e9c56d85a1f09605beae3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6532224 Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1458185}
Fixes the following Pylint warnings in GPU code that are surfaced when upgrading to Pylint 3.2: * unnecessary-lambda-assignment * superfluous-parens * consider-using-from-import * use-yield-from * possibly-used-before-assignment * used-before-assignment This should be the last of the warnings that need fixing before the upgrade can go through - the remaining warnings are ones that need to be fixed alongside the Pylint upgrade. Bug: 405148966 Change-Id: Ia51e6f35b437c0b159ef5f926d561834ec145835 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6527496 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/main@{#1458186}
https://chrome-internal.googlesource.com/clank/internal/apps.git/+log/a6def8f14f32..df53d073015a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/clank-apps-chromium-autoroll Please CC chrome-brapp-engprod@google.com,meiliang@google.com,sideyilmaz@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: chromium:414826060 Tbr: meiliang@google.com,sideyilmaz@google.com No-Try: true Change-Id: Iaa9da0884c36e154787fe6c8051b51e27f743c45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6532165 Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1458187}
This CL allows the ability to swap the currently active tab within a split with another tab. Updated tab strip model to provide support for this. Additionally, only using animation when creating a new split tab and not when update the split as per guidance from UX. Change-Id: I80ead3a714d1e5ff1e1e1dc2a607bb8199f53a63 Fixed: 414667744 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6501773 Reviewed-by: Alison Gale <agale@chromium.org> Commit-Queue: Eshwar Stalin <estalin@chromium.org> Cr-Commit-Position: refs/heads/main@{#1458188}
https://chromium.googlesource.com/chromiumos/chromite.git/+log/bf95ef3e710a..5141f5570d47 2025-05-08 kimjae@chromium.org lib: Add BuildCustomKernelImage high-level method 2025-05-08 kimjae@chromium.org lib: Improve build process robustness and clarity 2025-05-08 tomhughes@chromium.org contrib: Add chroot user to tty group 2025-05-08 vapier@chromium.org shell: enter_chroot: move /var/log/asan/ init to Python If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners-reviews@google.com,chrome-os-gardeners@google.com,chromeos-velocity@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-chrome Tbr: chrome-os-gardeners-reviews@google.com Change-Id: I434ce622f2e5d0a251918a2984b58aa085cbaf87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6531045 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1458189}
The variable lld_path is used to set the directory where the LLD executable lives. This is passed to the compiler driver with the -B flag. An empty string causes the -B argument to be omitted. Previously, lld_path was declared as a GN arg only when is_clang is false. This change makes it a GN arg unconditionally. This will be used to ensure the correct LLD binary is invoked when building Chrome for ChromeOS with its own toolchain from inside the ChromeOS chroot. Bug: 416316938 Test: Build Chrome in various configurations Change-Id: I47867d5e693f9c18e3439daba871f0ecbacabe76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6527648 Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Bob Haarman <inglorion@chromium.org> Cr-Commit-Position: refs/heads/main@{#1458190}
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202505090800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/qkyNFsVICJ-JrYiVUpRoWnxS6Xd23XJc21-bNMkItnwC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC cros-essential-apps-dev@chromium.org,help-app@grotations.appspotmail.com,jomag@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: help-app@grotations.appspotmail.com Change-Id: Ief552dfb12fb1d7340fa7b47fb44749bca082315 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6531047 Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1458191}
Exiting the test application causes future tests to fail. Those other tests are then likely to be disabled as flaky even though they are not the cause of the test flake, but rather an earlier test which moved the unittest app to the background. In a follow-up CL, I will attempt to enforce the app staying in the foreground to prevent this in the future. Bug: 409942614, 416541115 Change-Id: Ia23abb4046d9124c5e71485b0499764e28101317 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6526626 Reviewed-by: Rohit Rao <rohitrao@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Auto-Submit: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/main@{#1458192}
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cb1ada39b565..e61351743148 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC chrome-browser-infra-team,khushalsagar@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:389136009 Tbr: khushalsagar@google.com Change-Id: I01e7bd94fb7906e3383111ab50f69deae3f65a4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6531811 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1458193}
This change implements the presentation of the NTP step of the guided tour from the FirstRunProfileAgent. After the promo dismisses in response to the user opting in, the GuidedTourCoordinator will be started. Tapping on the "Next" button will send a signal to open the Tab Grid, the next step of the tour. Bug: 413461470 Change-Id: I3513fcbb99e2d9ff1be687057e0163fbcc6bfa68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6521264 Reviewed-by: Sergio Collazos <sczs@chromium.org> Commit-Queue: Ginny Huang <ginnyhuang@chromium.org> Auto-Submit: Chris Lu <thegreenfrog@google.com> Reviewed-by: Ginny Huang <ginnyhuang@chromium.org> Cr-Commit-Position: refs/heads/main@{#1458194}
This fixes some less-common cross-compile scenarios. Bug: None Change-Id: I3382dc93ffef6ee6d55bd0e0eba0563d53fc68c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6491047 Reviewed-by: Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Auto-Submit: Daniel Richard G. <iskunk@gmail.com> Cr-Commit-Position: refs/heads/main@{#1458195}
Roll Chrome Win32 PGO profile from chrome-win32-main-1746781162-fbcd078ad2b2bfcff52f8988a317e59faaf22fbe-e0c80fb82378662bfbda6b8d2ad8ab52a41c0415.profdata to chrome-win32-main-1746791612-db6dc6c307b34f3247a88fc82beeaadae347d690-4852d4ffeefa31265675175f00edcf84c5e30ecd.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Merge-Approval-Bypass: Chrome autoroller Change-Id: Ic966e4ce145fd633a2444d9718052faa7dc7186d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6531389 Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1458196}
…ift+Arrow" This is a reland of commit 14045a2 This contains the original change, plus a fix for a crash that occurred on Mac when invoking a menu while in immersive fullscreen. A similar change commit c08a424 attempted to fix this issue, but isn't a complete fix. It will be reverted once this CL lands. It attempts to listen to the key press events, but Win+Shift+Arrow is an OS special key combination which is eaten by the OS. This means the application never receives the key down for arrow when Win and Shift are already pressed. So the other CL is relying on the key up event. If the user releases Win or Shift keys before releasing the arrow key, then the context menu is not dismissed even though the browser window moves. Additionally, it doesn't handle up and down keys, it doesn't handle if the window is moved with Win+Arrow (no shift), and on single monitor displays, Win+Shift+Arrow does not move the browser window, but the other CL still closes the context menu. Using browser window move to dismiss the menu matches the behavior of existing UI like Datalist dropdown and select dropdown, which dismiss themselves when the browser window moves. Original change's description: > Fix context menu not dismissing when window moves with Win+Shift+Arrow > > The existing Destroying and ShowStateChanged callbacks, that > MenuController uses to cancel currently showing menus, don't handle the > case where the user moves the browser window using the keyboard shortcut > Win+Shift+Arrow. Adding a callback for BoundsChanged to cancel current > menus will handle the scenario where the user moves the browser window > with the keyboard. > > Bug: 394634481 > Change-Id: I8fcceb209dbd376eda8a683525dcfb891d364a40 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6244522 > Reviewed-by: Dana Fried <dfried@chromium.org> > Commit-Queue: Brad Peters <brpeters@microsoft.com> > Reviewed-by: Alison Gale <agale@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1427428} Bug: 394634481 Change-Id: If1ef4efb3a6d37be121d57a098daa4a2800c3348 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6474359 Reviewed-by: Dana Fried <dfried@chromium.org> Commit-Queue: Brad Peters <brpeters@microsoft.com> Reviewed-by: Liang Zhao <lzhao@microsoft.com> Reviewed-by: Alison Gale <agale@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/main@{#1458197}
Refactored BookmarkLocalDataBatchUploaderTest with the matchers introduced in this CL. These new matchers will be widely used in more batch upload tests in separate CLs. Bug: 390359692 Change-Id: I5dea4638bfea00cb9e752cd3186aae0176d1461a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6530426 Commit-Queue: Mahmoud Rashad <mmrashad@google.com> Reviewed-by: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/main@{#1458198}
…lity" This reverts commit 23af92f. Reason for revert: Test seems to be passing. Bug: 405940642 Original change's description: > [Gardener] Disable flaky ToolbarTest#testToggleTabStripVisibility > > Bug: 405940642 > Change-Id: I14d48396d1879ea7707b3bf66a86db6c7eae65a8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6387376 > Owners-Override: Ioana Pandele <ioanap@chromium.org> > Reviewed-by: Anna Tsvirchkova <atsvirchkova@google.com> > Auto-Submit: Ioana Pandele <ioanap@chromium.org> > Commit-Queue: Ioana Pandele <ioanap@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1436811} Bug: 405940642 Change-Id: I79b96466127e5d18d2615180c272a3b35ba15857 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6528549 Reviewed-by: Ioana Pandele <ioanap@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by: Wenyu Fu <wenyufu@chromium.org> Cr-Commit-Position: refs/heads/main@{#1458199}
Several macOS accessibility-events tests are flaky due to the occasional logging of accessibility events from the Back and Stop buttons. These events are not relevant to the DumpAccessibilityBrowser* tests. In fact, DumpAccessibilityTestBase::CaptureEvents() sets only_web_events_ to true. AXEventRecorderMac needs to check for this condition and not log non-web events. Add IsWebContent() to AXInspectUtilitiesMac and use it to filter these events out in AXEventRecorder::EventReceived. Bug: 415874090 Change-Id: I5c8152581d413ca7bb4b555309a47e91d481ee7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6519616 Reviewed-by: Jayson Adams <shrike@chromium.org> Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Joanmarie Diggs <jdiggs@igalia.com> Cr-Commit-Position: refs/heads/main@{#1458200}
Automatic update for 2025-05-09 UTC Merge-Approval-Bypass: pki-metadata-updater Change-Id: I70f00a8dd37a9969ea79deed369746e1d30b96a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6532026 Bot-Commit: PKI Metadata Updates Bot <mdb.chrome-pki-metadata-release-jobs@google.com> Commit-Queue: PKI Metadata Updates Bot <mdb.chrome-pki-metadata-release-jobs@google.com> Cr-Commit-Position: refs/heads/main@{#1458201}
Bug: 406991278 Change-Id: Ia108448381dca7aaa7c5efb2810f8d65c483a661 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6530841 Commit-Queue: Hubert Chao <hchao@chromium.org> Reviewed-by: Chris Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/main@{#1458202}
…ocal, FieldCanBeStatic (part 1) Bug: 40661145 Change-Id: I0649b65b8534a14bbd63f9326b7997133d51c767 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6531251 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by: Henrique Nakashima <hnakashima@chromium.org> Owners-Override: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/main@{#1458203}
In this part migrating - ui/destination_dialog.ts Bug: 410607166 Change-Id: I0fa589dbe98edcdac986c609af3527dfcf5a5859 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6521084 Reviewed-by: Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/main@{#1458204}
This CL changes the expectations that the letterboxing tests need to pass. For letterboxing, we need to ensure that the desktop plane is disabled when the letterboxing optimization is used, and also that the video gets properly letterboxed. This change affects the 5 letterboxing tests: FullScreenLetterboxingResizeVideoLayer FullScreenLetterboxingWithDesktopPlaneRemoval FullScreenLetterboxingKeepVisualInfo FullScreenPillarboxingResizeVideoLayer FullScreenPillarboxingWithDesktopPlaneRemoval Added 2 helper methods for all tests to use to check expectations: CheckVideoDisablesDesktopPlane and CheckVideoIsLetterboxedCorrectly Note: there are 3 MF-specific letterboxing tests that were not changed because they will be addressed in a follow-up CL. Change-Id: I3f372f2173a3c26779cecae99796b604ae8e9224 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6384309 Reviewed-by: Chunbo Hua <chunbo.hua@intel.com> Reviewed-by: Michael Tang <tangm@microsoft.com> Commit-Queue: Daniel Song <danielsong@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1458205}
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )