Conversation
AviVahl
commented
Dec 8, 2024
| @@ -1,255 +0,0 @@ | |||
| import { expect } from 'chai'; | |||
AviVahl
commented
Dec 8, 2024
| @@ -1,47 +0,0 @@ | |||
| import { createDisposables } from '@wixc3/create-disposables'; | |||
AviVahl
commented
Dec 8, 2024
| // Preload declares 2 messages, nodeCtx declares 1, procEnv declares 1 | ||
| const featureName = 'preload/preload-context'; | ||
|
|
||
| it('Runs only the node context preload, and runs it first, in dev mode', async () => { |
AviVahl
commented
Dec 8, 2024
| const disposables = createDisposables(); | ||
| afterEach(() => disposables.dispose()); | ||
|
|
||
| it('When loading a feature that depends on a feature that has preload, the preloads are still loaded first', async () => { |
AviVahl
force-pushed
the
avi/enough-is-enough
branch
3 times, most recently
from
6957708 to
13ab42e
Compare
AviVahl
commented
Dec 8, 2024
| @@ -1,604 +0,0 @@ | |||
| import { nodeFs as fs } from '@file-services/node'; | |||
Contributor
Author
There was a problem hiding this comment.
requires restoration
AviVahl
force-pushed
the
avi/enough-is-enough
branch
2 times, most recently
from
3a7859a to
1c6c1c0
Compare
AviVahl
commented
Dec 8, 2024
| @@ -1,463 +0,0 @@ | |||
| import chai, { expect } from 'chai'; | |||
Contributor
Author
There was a problem hiding this comment.
requires restoration (using newer node-env-manager)
AviVahl
commented
Dec 8, 2024
| @@ -1,449 +0,0 @@ | |||
| import { nodeFs as fs } from '@file-services/node'; | |||
Contributor
Author
There was a problem hiding this comment.
requires restoration
AviVahl
force-pushed
the
avi/enough-is-enough
branch
2 times, most recently
from
c597ac5 to
69f230b
Compare
- remove engineer, dashboard, webpack, stylable - moved still-used non-webpack code from engineer to engine-cli - switch from mocha-play to mocha-web - remove many more unused deps (types for debug, d3) - use express.json instead of using body-parser directly
AviVahl
force-pushed
the
avi/enough-is-enough
branch
from
69f230b to
040600b
Compare
Contributor
Author
|
reviewed file-by-file with Barak |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.